From: Guenter Roeck <linux@roeck-us.net>
To: Jisheng Zhang <jszhang@marvell.com>,
Doug Anderson <dianders@chromium.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Heiko Stuebner <heiko@sntech.de>,
Lunxue Dai <lunxue.dai@rock-chips.com>,
Dinh Nguyen <dinguyen@altera.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] watchdog: dw_wdt: pat the watchdog before enabling it
Date: Wed, 21 Jan 2015 21:31:42 -0800 [thread overview]
Message-ID: <54C08B3E.60302@roeck-us.net> (raw)
In-Reply-To: <20150122132200.4729d38b@xhacker>
On 01/21/2015 09:22 PM, Jisheng Zhang wrote:
> Dear Doug,
>
> On Wed, 21 Jan 2015 15:17:22 -0800
> Doug Anderson <dianders@chromium.org> wrote:
>
>> On some dw_wdt implementations the "top" register may be initted to 0
>> at bootup. In such a case, each "pat" of the watchdog will reset the
>> timer to 0xffff. That's pretty short.
>
> + Guenter Roeck
>
> This should have been fixed by dfa07141e7a792("watchdog: dw_wdt: initialise
> TOP_INIT in dw_wdt_set_top()")
>
Ah, yes. Doug, can you check if your patch is still needed ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-01-22 5:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 23:17 [PATCH 1/2] watchdog: dw_wdt: pat the watchdog before enabling it Doug Anderson
2015-01-21 23:17 ` [PATCH 2/2] watchdog: dw_wdt: Try to get a 30 second watchdog by default Doug Anderson
2015-01-21 23:36 ` Guenter Roeck
2015-01-21 23:35 ` [PATCH 1/2] watchdog: dw_wdt: pat the watchdog before enabling it Guenter Roeck
2015-01-22 5:22 ` Jisheng Zhang
2015-01-22 5:31 ` Guenter Roeck [this message]
2015-01-22 17:09 ` Doug Anderson
2015-01-23 16:03 ` Guenter Roeck
2015-01-23 16:20 ` Doug Anderson
2015-01-23 17:02 ` Guenter Roeck
2015-01-26 6:22 ` Jisheng Zhang
2015-01-26 17:01 ` Doug Anderson
2015-01-27 3:44 ` Jisheng Zhang
2015-01-27 4:07 ` Guenter Roeck
2015-01-27 4:36 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C08B3E.60302@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dianders@chromium.org \
--cc=dinguyen@altera.com \
--cc=heiko@sntech.de \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lunxue.dai@rock-chips.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox