From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752115AbbAVJnO (ORCPT ); Thu, 22 Jan 2015 04:43:14 -0500 Received: from outbound-smtp04.blacknight.com ([81.17.249.35]:59151 "EHLO outbound-smtp04.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbbAVJnJ (ORCPT ); Thu, 22 Jan 2015 04:43:09 -0500 Message-ID: <54C0C628.2050107@nexus-software.ie> Date: Thu, 22 Jan 2015 09:43:04 +0000 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Andy Shevchenko CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, dvhart@infradead.org, boon.leong.ong@intel.com, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000 References: <1421865968-7373-1-git-send-email-pure.logic@nexus-software.ie> <1421865968-7373-2-git-send-email-pure.logic@nexus-software.ie> <54C05207.6010306@nexus-software.ie> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/01/15 08:59, Andy Shevchenko wrote: >> It was size >> 10 for V1 and you called it out as a magic number :) >> >> IMO, size / 1024 requires less thought to understand when reading the code. > > Oh, my bad. Now a bit modified suggestion, to add KiB inside format > string and leave / 1024. Would it work for you? Sure thing. Makes sense to me. -- BOD