From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
rtc-linux@googlegroups.com
Cc: linux-kernel@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [rtc-linux] [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element
Date: Thu, 22 Jan 2015 15:01:22 +0300 [thread overview]
Message-ID: <54C0E692.7000806@samsung.com> (raw)
In-Reply-To: <CAJKOXPfuxD91=hEYoTQ2Vdes+cf-FXGUZRD2HUbeNzS3czKobA@mail.gmail.com>
On 01/22/2015 12:37 PM, Krzysztof Kozlowski wrote:
> 2015-01-21 16:06 GMT+01:00 Andrey Ryabinin <a.ryabinin@samsung.com>:
>> Array of platform_device_id elements should be terminated
>> with empty element.
>>
>> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
>> ---
>> drivers/rtc/rtc-s5m.c | 1 +
>> 1 file changed, 1 insertion(+)
>
>
> Right, good catch.
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Maybe also cc stable for fixing 5bccae6ec458 ("rtc: s5m-rtc: add
> real-time clock driver for s5m8767")?
>
Probably. I didn't add stable tag because, I have no idea what are runtime
effects of this bug, so I don't know whether this worth for stable or not.
prev parent reply other threads:[~2015-01-22 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 15:06 [PATCH] rtc: s5m: terminate s5m_rtc_id array with empty element Andrey Ryabinin
2015-01-22 9:37 ` [rtc-linux] " Krzysztof Kozlowski
2015-01-22 12:01 ` Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0E692.7000806@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=a.zummo@towertech.it \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox