From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbbAVMXl (ORCPT ); Thu, 22 Jan 2015 07:23:41 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:47115 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbbAVMXg (ORCPT ); Thu, 22 Jan 2015 07:23:36 -0500 Message-ID: <54C0EBC5.7060606@linaro.org> Date: Thu, 22 Jan 2015 13:23:33 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Baruch Siach , Thomas Gleixner CC: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] clocksource: devicetree: document Conexant Digicolor timer binding References: <6812ad4ac585e40ad7d8282eef1d64be8bc6eaa5.1421821466.git.baruch@tkos.co.il> In-Reply-To: <6812ad4ac585e40ad7d8282eef1d64be8bc6eaa5.1421821466.git.baruch@tkos.co.il> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2015 07:36 AM, Baruch Siach wrote: > Signed-off-by: Baruch Siach Please add a changelog and a more verbose description: see for example commit 2f2b7fb2 or 926b65e2. If there is a public documentation please add a link to it or give a quick description of how the timer behaves. Also that will help to review the code in the timer. > --- > .../devicetree/bindings/timer/digicolor-timer.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/digicolor-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/digicolor-timer.txt b/Documentation/devicetree/bindings/timer/digicolor-timer.txt > new file mode 100644 > index 000000000000..d1b659bbc29f > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/digicolor-timer.txt > @@ -0,0 +1,18 @@ > +Conexant Digicolor SoCs Timer Controller > + > +Required properties: > + > +- compatible : should be "cnxt,cx92755-timer" > +- reg : Specifies base physical address and size of the "Agent Communication" > + timer registers > +- interrupts : Contains 8 interrupts, one for each timer > +- clocks: phandle to the main clock > + > +Example: > + > + timer@f0000fc0 { > + compatible = "cnxt,cx92755-timer"; > + reg = <0xf0000fc0 0x40>; > + interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>; > + clocks = <&main_clk>; > + }; > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog