From: Julien Grall <julien.grall@linaro.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
david.vrabel@citrix.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org
Cc: kvm@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@suse.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>
Subject: Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted
Date: Thu, 22 Jan 2015 13:10:49 +0000 [thread overview]
Message-ID: <54C0F6D9.70003@linaro.org> (raw)
In-Reply-To: <1421893039-426-3-git-send-email-mcgrof@do-not-panic.com>
Hi Luis,
On 22/01/15 02:17, Luis R. Rodriguez wrote:
> diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
> index b4bca2d..23c526b 100644
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -32,6 +32,8 @@
> #include <linux/slab.h>
> #include <linux/irqnr.h>
> #include <linux/pci.h>
> +#include <linux/sched.h>
> +#include <linux/kprobes.h>
>
> #ifdef CONFIG_X86
> #include <asm/desc.h>
> @@ -1243,6 +1245,17 @@ void xen_evtchn_do_upcall(struct pt_regs *regs)
> set_irq_regs(old_regs);
> }
>
> +notrace void xen_end_upcall(struct pt_regs *regs)
> +{
> + if (!xen_is_preemptible_hypercall(regs) ||
I don't see any definition of xen_is_preemptible_hypercall for ARM32/ARM64.
As this function is called from the generic code, you have at least to
stub this function for those architectures.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-01-22 13:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 2:17 [RFC v3 0/2] x86/xen: add xen hypercall preemption Luis R. Rodriguez
2015-01-22 2:17 ` [RFC v3 1/2] x86/xen: add xen_is_preemptible_hypercall() Luis R. Rodriguez
2015-01-22 3:07 ` Andy Lutomirski
2015-01-22 19:30 ` Luis R. Rodriguez
2015-01-22 20:01 ` Andy Lutomirski
2015-01-22 21:09 ` Luis R. Rodriguez
2015-01-22 21:44 ` Andrew Cooper
2015-01-22 22:44 ` Luis R. Rodriguez
2015-01-22 2:17 ` [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted Luis R. Rodriguez
2015-01-22 3:18 ` Andy Lutomirski
2015-01-22 12:55 ` [Xen-devel] " David Vrabel
2015-01-22 17:56 ` Luis R. Rodriguez
2015-01-22 19:30 ` Luis R. Rodriguez
2015-01-22 11:50 ` [Xen-devel] " Andrew Cooper
2015-01-22 13:56 ` Steven Rostedt
2015-01-22 18:39 ` Luis R. Rodriguez
2015-01-22 20:16 ` Steven Rostedt
2015-01-22 20:24 ` Andy Lutomirski
2015-01-22 20:37 ` Steven Rostedt
2015-01-22 20:58 ` Andy Lutomirski
2015-01-22 21:16 ` Steven Rostedt
2015-01-22 21:21 ` Andy Lutomirski
2015-01-22 22:29 ` Andrew Cooper
2015-01-22 21:07 ` Paul E. McKenney
2015-01-22 18:41 ` Luis R. Rodriguez
2015-01-22 13:10 ` Julien Grall [this message]
2015-01-22 18:56 ` Luis R. Rodriguez
2015-01-22 20:31 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0F6D9.70003@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).