From: Paolo Bonzini <pbonzini@redhat.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Mario Smarduch <m.smarduch@samsung.com>,
Valentin Rothberg <valentinrothberg@gmail.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Gleb Natapov <gleb@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT?
Date: Thu, 22 Jan 2015 16:32:37 +0100 [thread overview]
Message-ID: <54C11815.8070501@redhat.com> (raw)
In-Reply-To: <1421938175.13638.58.camel@x220>
On 22/01/2015 15:49, Paul Bolle wrote:
>> > Ah, there are two Kconfig symbols added by mistake.
>> >
>> > +config HAVE_KVM_ARCH_DIRTY_LOG_PROTECT
>> > + bool
>> > +
>> > +config KVM_GENERIC_DIRTYLOG_READ_PROTECT
>> > + bool
> This one is actually used (so my 800 line perl monster didn't bark):
> $ git grep -n KVM_GENERIC_DIRTYLOG_READ_PROTECT next-20150122
> next-20150122:arch/arm/kvm/Kconfig:27: select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> next-20150122:arch/arm64/kvm/Kconfig:30: select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> next-20150122:arch/x86/kvm/Kconfig:42: select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> next-20150122:virt/kvm/Kconfig:47:config KVM_GENERIC_DIRTYLOG_READ_PROTECT
> next-20150122:virt/kvm/kvm_main.c:998:#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT
>
Yes, the mistake is adding two symbols instead of one. :)
Paolo
next prev parent reply other threads:[~2015-01-22 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 9:19 KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT? Paul Bolle
2015-01-22 11:46 ` Paolo Bonzini
2015-01-22 17:47 ` Mario Smarduch
2015-01-22 13:57 ` Paolo Bonzini
2015-01-22 14:49 ` Paul Bolle
2015-01-22 15:32 ` Paolo Bonzini [this message]
2015-01-23 9:48 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C11815.8070501@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.smarduch@samsung.com \
--cc=pebolle@tiscali.nl \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).