From: Guenter Roeck <linux@roeck-us.net>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jean Delvare <jdelvare@suse.de>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/hwmon/adc128d818.c: Do proper sign extension
Date: Thu, 22 Jan 2015 15:16:32 -0800 [thread overview]
Message-ID: <54C184D0.6080509@roeck-us.net> (raw)
In-Reply-To: <1421966655-16188-2-git-send-email-linux@rasmusvillemoes.dk>
On 01/22/2015 02:44 PM, Rasmus Villemoes wrote:
> data->temp[index] has type s16. Because of C's promotion rules,
> (data->temp[index] << 7) >> 7 is exactly the same as
> data->temp[index]. The intention was to use bit 8 as a sign bit, so do
> that using the existing API.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2015-01-22 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 22:44 [PATCH 1/2] drivers/hwmon/ad7314.c: Do proper sign extension Rasmus Villemoes
2015-01-22 22:44 ` [PATCH 2/2] drivers/hwmon/adc128d818.c: " Rasmus Villemoes
2015-01-22 23:16 ` Guenter Roeck [this message]
2015-01-22 23:16 ` [PATCH 1/2] drivers/hwmon/ad7314.c: " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C184D0.6080509@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox