From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756141AbbAWRHJ (ORCPT ); Fri, 23 Jan 2015 12:07:09 -0500 Received: from mail-pd0-f176.google.com ([209.85.192.176]:46698 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755503AbbAWRHF (ORCPT ); Fri, 23 Jan 2015 12:07:05 -0500 Message-ID: <54C27FB5.7070904@acm.org> Date: Fri, 23 Jan 2015 11:07:01 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: nick , Sasha Levin CC: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] char:ipmi: Free ipmi_recv_msg messages from the linked list,recv_msgs for the function,ipmi_release in the file,ipmi_devintf.c References: <1421723653-19633-1-git-send-email-xerofoify@gmail.com> <54C0F59B.8090709@acm.org> <54C1D30B.8090705@oracle.com> <54C27857.8030203@gmail.com> In-Reply-To: <54C27857.8030203@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2015 10:35 AM, nick wrote: > Sasha, > How is this patch broken? It builds and clearly frees > the list entries. Please explain how to me. > Nick Oh, it does not free priv. That code should not have been removed. -corey > On 2015-01-22 11:50 PM, Sasha Levin wrote: >> On 01/22/2015 08:05 AM, Corey Minyard wrote: >>> Patch is queued for 3.20. Thanks. >> That patch is horribly broken. >> >> >> Thanks, >> Sasha >> >>> -corey >>> >>> On 01/19/2015 09:14 PM, Nicholas Krause wrote: >>>> This adds a loop through the elements in the linked list, recv_msgs using >>>> list_for_entry_safe in order to free messages in this list. In addition >>>> we are using the safe version of this marco in order to prevent use after >>>> bugs related to deleting the element we are on currently by holding a >>>> pointer to the next element after the current one we are on and freeing >>>> with the function, ipmi_free_recv_msg internally in this loop. >>>> >>>> Signed-off-by: Nicholas Krause >>>> --- >>>> drivers/char/ipmi/ipmi_devintf.c | 7 ++++--- >>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c >>>> index ec318bf..d2af38a 100644 >>>> --- a/drivers/char/ipmi/ipmi_devintf.c >>>> +++ b/drivers/char/ipmi/ipmi_devintf.c >>>> @@ -157,14 +157,15 @@ static int ipmi_release(struct inode *inode, struct file *file) >>>> { >>>> struct ipmi_file_private *priv = file->private_data; >>>> int rv; >>>> + struct ipmi_recv_msg *msg, *next; >>>> >>>> rv = ipmi_destroy_user(priv->user); >>>> if (rv) >>>> return rv; >>>> >>>> - /* FIXME - free the messages in the list. */ >>>> - kfree(priv); >>>> - >>>> + list_for_each_entry_safe(msg, next, &priv->recv_msgs, link) { >>>> + ipmi_free_recv_msg(msg); >>>> + } >>>> return 0; >>>> } >>>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >>>