From: Sasha Levin <sasha.levin@oracle.com>
To: minyard@acm.org, nick <xerofoify@gmail.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] char:ipmi: Free ipmi_recv_msg messages from the linked list,recv_msgs for the function,ipmi_release in the file,ipmi_devintf.c
Date: Fri, 23 Jan 2015 20:32:21 -0500 [thread overview]
Message-ID: <54C2F625.5010204@oracle.com> (raw)
In-Reply-To: <54C29A51.1050904@acm.org>
On 01/23/2015 02:00 PM, Corey Minyard wrote:
> On 01/23/2015 12:27 PM, nick wrote:
>> > Corney,
>> > Hope this patch fixes the issue. Sorry about missing that kfree
>> > being required. :(
> Well, the kfree needs to be after the free of the messages. You can't
> use an item after you free it.
As you can see, his patches aren't event tested. See https://lkml.org/lkml/2014/8/4/206 .
Thanks,
Sasha
prev parent reply other threads:[~2015-01-24 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1422036143-27808-1-git-send-email-xerofoify@gmail.com>
[not found] ` <54C292A7.9090000@gmail.com>
2015-01-23 19:00 ` [PATCHv2] char:ipmi: Free ipmi_recv_msg messages from the linked list,recv_msgs for the function,ipmi_release in the file,ipmi_devintf.c Corey Minyard
2015-01-24 1:32 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C2F625.5010204@oracle.com \
--to=sasha.levin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).