From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbbAXV4s (ORCPT ); Sat, 24 Jan 2015 16:56:48 -0500 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:43557 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbbAXV4r (ORCPT ); Sat, 24 Jan 2015 16:56:47 -0500 Message-ID: <54C4151D.2080306@nexus-software.ie> Date: Sat, 24 Jan 2015 21:56:45 +0000 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Andy Shevchenko , "Ong, Boon Leong" CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "dvhart@infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/1] x86: Add Isolated Memory Regions for Quark X1000 References: <1421865968-7373-1-git-send-email-pure.logic@nexus-software.ie> <1421865968-7373-2-git-send-email-pure.logic@nexus-software.ie> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/15 11:02, Andy Shevchenko wrote: > On Sat, Jan 24, 2015 at 3:48 AM, Ong, Boon Leong > wrote: > >>> +static int imr_enabled(struct imr_regs *imr) >> Do we want to make it inline perhaps since it is 1 liner? > > Since it is declared static I would even suggest the new name is_imr_enabled(). I think imr_is_enabled() is a better name. Every other function is imr_ prefixed. >>> + >>> + if ((imr_to_phys(imr.addr_lo) == base) && >>> + (imr_to_phys(imr.addr_hi) == max)) { >> I think we need to take care of the size that has been fix-up here ... >> >>> + found = 1; >>> + reg = i; > > According to your comment this line becomes redundant. > Ah but I still think though. We eventually do an imr_write(reg, &imr); which I think reads better than imr_write(i, &imr); -- BOD