Re: [PATCH RFC 2/2] perf: convert: fix duplicate field names and avoid reserved keywords.

[Wang Nan <wangnan0@huawei.com>]

Hi all,

I posted a new series of patches for this problem. I open another thread to avoid
disorder this thread. Please see:

https://lkml.org/lkml/2015/1/26/198

Thank you.

On 2015/1/25 0:39, Jiri Olsa wrote:
> On Fri, Jan 23, 2015 at 05:40:02PM -0500, Jérémie Galarneau wrote:
> 
> SNIP
> 
>>> bt_ctf_clock_create() with the checked name and then free it. However, it is hacky
>>> and I think you won't like it.
>>
>> The prospect of seeing that code has convinced me to introduce
>> int bt_ctf_validate_identifier(const char *identifier);
>>
>> commit 654c1444b546fd79b209288b93ed4e87d9bb8a2b
>> Author: Jérémie Galarneau <jeremie.galarneau@efficios.com>
>> Date:   Fri Jan 23 16:24:52 2015 -0500
>>
>>     Add utility function to validate CTF identifiers
>>
>>     Introduces bt_ctf_validate_identifier() which validates a given
>>     identifier against the list of CTF reserved keywords.
>>
>>     This function may evolve to perform additional validity checks in
>>     the future as the CTF specification moves forward.
>>
>>     Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>>     Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
>>
>>
>> Does that take care of the problem?
> 
> seems good to me, thanks
> 
> jirka
>