From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755842AbbAZPYr (ORCPT ); Mon, 26 Jan 2015 10:24:47 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:57079 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbbAZPYn (ORCPT ); Mon, 26 Jan 2015 10:24:43 -0500 Message-ID: <54C65C36.9050106@atmel.com> Date: Mon, 26 Jan 2015 16:24:38 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bo Shen , Mark Brown CC: , , , , , Alexander Morozov Subject: Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table References: <1418614273-2303-1-git-send-email-voice.shen@atmel.com> <20150115115425.GX3043@sirena.org.uk> <54B866B9.8000900@atmel.com> In-Reply-To: <54B866B9.8000900@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 16/01/2015 02:17, Bo Shen a écrit : > Hi Mark, > > On 01/15/2015 07:54 PM, Mark Brown wrote: >> On Mon, Dec 15, 2014 at 11:31:11AM +0800, Bo Shen wrote: >> >>> +#ifdef CONFIG_OF >>> +static enum wm8904_type wm8904_data = WM8904; >>> +static enum wm8904_type wm8912_data = WM8912; >>> + >>> +static const struct of_device_id wm8904_of_match[] = { >>> + { >>> + .compatible = "wlf,wm8904", >>> + .data = &wm8904_data, >> >> Does this end up in the i2c_driver_id driver data or do we need some >> extra code when devtype is assigned to check for an of_node and look at >> the DT data instead? That certainly used to be the case... > > At the beginning I think as the same as you, and also add the code to > get the data as I do in . However, as I > remember, I2C seems only use the compatible string after the comma, that > means only for "wlf,wm8904", it uses "wm8904" to match. So, I remove all > the code I added, and just keep these, and it can get the device type > correctly. > > So, when I submit the patch and keep the code as simple as possible. > > Thanks. > > Best Regards, > Bo Shen I don't understand what's keeping this patch from being applied. Voice, do you mind re-sending? On my side, I take the two patches that apply on AT91 DT (2/3 and 3/3). Bye, -- Nicolas Ferre