Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

Greg Kroah-Hartman
2015-01-26T22:46:58Z

On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
> > make ARCH=i386 allyesconfig fails with
> >
> > drivers/staging/built-in.o: In function `reset':
> > (.text+0x2ae89d): multiple definition of `reset'
> > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here
> > make[1]: *** [drivers/built-in.o] Error 1
>
> Culprit:
>
> commit b2ebd4be6fa1d2329b63531b044f9e25474981cb
> Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Date: Wed Dec 31 10:11:10 2014 +0100
>
> staging: fbtft: add fb_agm1264k-fl driver
>
> A global function named 'reset' isn't really a good idea.
>
> Not that the global function with the same name in the isdn code
> is better ;-).

Agreed, the fbtft code is now fixed. Patches to fix the isdn code would
be gladly accepted as well :)

thanks,

greg k-h