From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758167AbbA0MG5 (ORCPT ); Tue, 27 Jan 2015 07:06:57 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbA0MG4 (ORCPT ); Tue, 27 Jan 2015 07:06:56 -0500 Message-ID: <54C77F5D.30302@nod.at> Date: Tue, 27 Jan 2015 13:06:53 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Alexander Holler CC: linux-mmc@vger.kernel.org, LKML , Chris Ball , Ulf Hansson Subject: Re: [PATCH] mmc: print message if a card supports secure erase/trim References: <1422359304-30321-1-git-send-email-holler@ahsoftware.de> <54C77E69.7050600@ahsoftware.de> In-Reply-To: <54C77E69.7050600@ahsoftware.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.01.2015 um 13:02 schrieb Alexander Holler: > Am 27.01.2015 um 12:55 schrieb Richard Weinberger: >> On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler wrote: >>> It's an interesting detail, so inform the user about it. >>> >>> Signed-off-by: Alexander Holler >>> --- >>> drivers/mmc/core/bus.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c >>> index 8a1f124..4a60028 100644 >>> --- a/drivers/mmc/core/bus.c >>> +++ b/drivers/mmc/core/bus.c >>> @@ -347,6 +347,10 @@ int mmc_add_card(struct mmc_card *card) >>> uhs_bus_speed_mode, type, card->rca); >>> } >>> >>> + if (mmc_can_secure_erase_trim(card)) >>> + pr_info("%s: card supports secure erase/trim\n", >>> + mmc_hostname(card->host)); >>> + >> >> Please make this a sysfs attribute. >> Exposing such properties as log messages is horrible. > > Look at the source at the message which is printed just before and decide which one you find more informational / useful. -ENOPARSE Thanks, //richard