From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932378AbbA0N3G (ORCPT ); Tue, 27 Jan 2015 08:29:06 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:46648 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbbA0N24 (ORCPT ); Tue, 27 Jan 2015 08:28:56 -0500 Message-ID: <54C79293.8030103@mm-sol.com> Date: Tue, 27 Jan 2015 15:28:51 +0200 From: Stanimir Varbanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Stephen Boyd CC: Linus Walleij , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf References: <1422289494-31461-1-git-send-email-svarbanov@mm-sol.com> <54C6E753.606@codeaurora.org> <54C6E89E.2050701@codeaurora.org> In-Reply-To: <54C6E89E.2050701@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2015 03:23 AM, Stephen Boyd wrote: > On 01/26/15 17:18, Stephen Boyd wrote: >> On 01/26/15 08:24, Stanimir Varbanov wrote: >> >>> return -ENOTSUPP; >>> } >>> >>> @@ -208,14 +208,12 @@ static int msm_config_get(struct pinctrl_dev *pctldev, >>> unsigned int pin, >>> unsigned long *config) >>> { >>> - dev_err(pctldev->dev, "pin_config_set op not supported\n"); >> Same for here. >> >>> return -ENOTSUPP; >>> } >>> >>> static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin, >>> unsigned long *configs, unsigned num_configs) >>> { >>> - dev_err(pctldev->dev, "pin_config_set op not supported\n"); >> And here. > > Actually it looks like we can just remove these two functions and the > core does the right thing and prints errors. That would be a good patch. > Agreed. -- regards, Stan