Re: [Patch v2 0/2] firmware: dmi-sysfs: add SMBIOS entry point area raw attribute

[Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>]

On 01/27/2015 06:23 PM, Grant Likely wrote:
> On Mon, 26 Jan 2015 15:28:36 +0200
> , Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
>   wrote:
>> Some utils, like dmidecode and smbios, needs to access SMBIOS entry
>> table area in order to get information like SMBIOS version, size, etc.
>> Currently it's done via /dev/mem. But for situation when /dev/mem
>> usage is disabled, the utils have to use dmi sysfs instead, which
>> doesn't represent SMBIOS entry. So this patch series adds SMBIOS
>> area to dmi sysfs in order to allow utils in question to work
>> correctly with dmi sysfs.
>>
>> v1: https://lkml.org/lkml/2015/1/23/643
> Hi Ivan,
>
> The change looks good to me, but it is an ABI addition, so it needs to
> be documented. You'll need to add a description to:
>
> Documentation/ABI/testing/sysfs-testing/sysfs-firmware-dmi

Ups...
Ok, It'll be in Documentation/ABI/testing/sysfs-firmware-dmi
Thanks!

>
> Second, (minor point), there is no reason to split this up into two
> patches. It is one feature, and would be better as a single patch.
>
> g.

Ok, it'll be one patch, including documentation

>
>> v2..v1:
>>    firmware: dmi_scan: add symbol to get SMBIOS entry area
>> 	- used additional static var to hold SMBIOS raw table size
>> 	- changed format of get_smbios_entry_area symbol
>> 	  returned pointer on const smbios table
>>
>>    firmware: dmi-sysfs: add SMBIOS entry point area attribute
>> 	- adopted to updated get_smbios_entry_area symbol
>>    	- removed redundant array to save smbios table
>>
>> Ivan Khoronzhuk (2):
>>    firmware: dmi_scan: add symbol to get SMBIOS entry area
>>    firmware: dmi-sysfs: add SMBIOS entry point area attribute
>>
>>   drivers/firmware/dmi-sysfs.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>>   drivers/firmware/dmi_scan.c  | 26 ++++++++++++++++++++++++++
>>   include/linux/dmi.h          |  3 +++
>>   3 files changed, 71 insertions(+)
>>
>> -- 
>> 1.9.1
>>