From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbbA1UNE (ORCPT ); Wed, 28 Jan 2015 15:13:04 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:56136 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753719AbbA1UNA (ORCPT ); Wed, 28 Jan 2015 15:13:00 -0500 Message-ID: <54C92878.3030207@ti.com> Date: Wed, 28 Jan 2015 13:20:40 -0500 From: Murali Karicheri User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Arnd Bergmann CC: David Miller , , , Subject: Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support References: <1421367007-19744-1-git-send-email-m-karicheri2@ti.com> <20150119.151106.822126941934010309.davem@davemloft.net> <54BE7A00.2020205@ti.com> <25883654.BLFxICW9P0@wuerfel> <54C91328.6030208@ti.com> <54C91FDD.1000009@ti.com> In-Reply-To: <54C91FDD.1000009@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2015 12:43 PM, Murali Karicheri wrote: > On 01/28/2015 11:49 AM, Murali Karicheri wrote: >> On 01/27/2015 05:28 PM, Arnd Bergmann wrote: >>> On Tuesday 20 January 2015 10:53:36 Murali Karicheri wrote: >>>> On 01/19/2015 03:11 PM, David Miller wrote: >>>>> From: Murali Karicheri >>>>> Date: Thu, 15 Jan 2015 19:10:03 -0500 >>>>> >>>>>> The Network Coprocessor (NetCP) is a hardware accelerator that >>>>>> processes >>>>>> Ethernet packets. NetCP has a gigabit Ethernet (GbE) subsystem with >>>>>> a ethernet >>>>>> switch sub-module to send and receive packets. NetCP also includes >>>>>> a packet >>>>>> accelerator (PA) module to perform packet classification operations >>>>>> such as >>>>>> header matching, and packet modification operations such as checksum >>>>>> generation. NetCP can also optionally include a Security >>>>>> Accelerator(SA) >>>>>> capable of performing IPSec operations on ingress/egress packets. >>>>>> >>>>>> Keystone SoC's also have a 10 Gigabit Ethernet Subsystem (XGbE) which >>>>>> includes a 3-port Ethernet switch sub-module capable of 10Gb/s and >>>>>> 1Gb/s rates per Ethernet port. >>>>>> >>>>>> Both GBE and XGBE network processors supported using common >>>>>> driver. It >>>>>> is also designed to handle future variants of NetCP. >>>>> >>>>> Series applied to net-next, thanks. >>>> David, >>>> >>>> Thanks a lot for applying this series. This helps us move forward to >>>> work on the next set of patches. >>> >>> Hi Murali, >>> >>> Building an ARM 'allmodconfig' kernel now runs into two separate >>> problems >>> from your driver: >>> >>> - you have two module_init() instances in one module, which conflict. >>> >>> - you have two files that are linked into more than one module, so >>> building >>> both TI_CPSW and TI_KEYSTONE_NETCP in the same kernel fails. >>> >>> The answer to both of these is probably to have separate loadable >>> modules, >>> but you might be able to come up with a different solution. >> Arnd, >> >> Thanks for letting us know. We will look into this. >> >> How do I reproduce this? Is there a defconfig used for allmodconfig? I >> am unable to find one. Any details to reproduce this will be useful. >> > Ok I think I found it. > > I did this with next-next branch and it seems to work. I will make > kernel build to reproduce this. > > make ARCH=arm allmodconfig > make uImage; > > I am building it now. Arnd, I see allmodconfig configure NetCP driver as module. My uImage build from net-next branch went through fine. I am building modules right now and should show error as you have pointed out. Let me know if you any issues on how I am working to reproduce the issue (wrong branch, wrong /incomplete commands etc. I have my CROSS_COMPILE and ARCH set in my env). Want to reproduce this so as to make sure my fix is addressing this. Hope I am on the right track. Thanks Murali > > Murali >> Thanks. >> >> Murali >>> >>> Arnd >> >> > > -- Murali Karicheri Linux Kernel, Texas Instruments