From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759605AbbA2EWd (ORCPT ); Wed, 28 Jan 2015 23:22:33 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:56297 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754543AbbA2EWb (ORCPT ); Wed, 28 Jan 2015 23:22:31 -0500 Message-ID: <54C9B584.6060302@roeck-us.net> Date: Wed, 28 Jan 2015 20:22:28 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm: split up mm_struct to separate header file References: <1422451064-109023-1-git-send-email-kirill.shutemov@linux.intel.com> <1422451064-109023-3-git-send-email-kirill.shutemov@linux.intel.com> <20150129003028.GA17519@node.dhcp.inet.fi> In-Reply-To: <20150129003028.GA17519@node.dhcp.inet.fi> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020205.54C9B587.004A,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 1 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2015 04:30 PM, Kirill A. Shutemov wrote: > On Wed, Jan 28, 2015 at 03:17:42PM +0200, Kirill A. Shutemov wrote: >> We want to use __PAGETABLE_PMD_FOLDED in mm_struct to drop nr_pmds if >> pmd is folded. __PAGETABLE_PMD_FOLDED is defined in , but >> itself wants for struct page >> definition. >> >> This patch move mm_struct definition into separate header file in order >> to fix circular header dependencies. >> >> Signed-off-by: Kirill A. Shutemov > > Guenter, below is update for the patch. It doesn't fix all the issues, but > you should see an improvement. I'll continue with this tomorrow. Yes, this is much better than before. Build results: total: 134 pass: 122 fail: 12 Failed builds: arm:imx_v6_v7_defconfig arm:s3c6400_defconfig cris:artpec_3_defconfig cris:etraxfs_defconfig hexagon:defconfig m68k:m5475evb_defconfig mips:allmodconfig s390:defconfig sparc64:defconfig sparc64:allmodconfig unicore32:defconfig xtensa:allmodconfig Qemu tests: total: 30 pass: 28 fail: 2 Failed tests: sparc64:sparc_smp_defconfig sparc64:sparc_nosmp_defconfig Some of the problems are inherited from mmotm. Here are the mmotm build results (v3.19-rc6-462-g995c249): total: 134 pass: 128 fail: 6 Failed builds: arm:imx_v6_v7_defconfig arm:s3c6400_defconfig mips:allmodconfig sparc64:allmodconfig unicore32:defconfig xtensa:allmodconfig Qemu tests: total: 30 pass: 30 fail: 0 With this, we can conclude that your patch series still has problems (at least) with cris, hexagon, m68k, s390, sparc, and unicore32. Guenter