From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756040AbbA2MkG (ORCPT ); Thu, 29 Jan 2015 07:40:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40036 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753828AbbA2Mjr (ORCPT ); Thu, 29 Jan 2015 07:39:47 -0500 Message-ID: <54CA2A10.5050801@suse.cz> Date: Thu, 29 Jan 2015 13:39:44 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Paul Bolle CC: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] kconfig: warn if an unknown symbol is selected References: <1412100583.21730.31.camel@x220> <1415014691.20372.49.camel@x220> <1422438897.5666.23.camel@x220> <54C8FFBA.5040000@suse.cz> <1422480756.3621.52.camel@x220> In-Reply-To: <1422480756.3621.52.camel@x220> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-01-28 22:32, Paul Bolle wrote: > On Wed, 2015-01-28 at 16:26 +0100, Michal Marek wrote: >> On 2015-01-28 10:54, Paul Bolle wrote: >>> Now that we've been told Yann has disappeared, would you consider taking >>> this patch into one of your trees? It would be nice to have people >>> actually use it for a while. >>> >>> Or should we first clean up (most of) the warnings it generates? There >> >> It seems your fixes have been accepted in the meantime, but there is one >> new: >> *** Default configuration is based on 'x86_64_defconfig' >> drivers/misc/cxl/Kconfig:8:warning: 'CXL_BASE' selects unknown symbol >> 'PPC_COPRO_BASE' >> >> PPC_COPRO_BASE is not known on x86, but at the same time, there is no >> way for CXL_BASE to be selected on x86: >> >> config CXL_BASE >> bool >> default n >> select PPC_COPRO_BASE >> >> config CXL >> tristate "Support for IBM Coherent Accelerators (CXL)" >> depends on PPC_POWERNV && PCI_MSI >> select CXL_BASE >> default m >> >> Shouldn't we only warn about a select when it is triggered? An >> allyesconfig would still report all bogus selects for given architecture. > > Good catch! I think checking only for selects done by Kconfig symbols > that are not "n" might do the trick. Expect a v2 one of these days. > > The current load of issues (for allyesconfig on all arches except um) is > pasted at the bottom of this message (with some comments added). Looking > at that load I think it might be preferable to first most of fix those > issues before adding this to kconfig. Maybe. OTOH, you have no warnings on x86 and powerpc and you already have patches for the arm(64) warnings, so I think this can go in. Michal