From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@fb.com>,
<linux-kernel@vger.kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH 2/2] blk-mq: release mq's kobjects in blk_release_queue()
Date: Thu, 29 Jan 2015 13:49:29 +0100 [thread overview]
Message-ID: <54CA2C59.2090607@sandisk.com> (raw)
In-Reply-To: <1422533847-31726-3-git-send-email-ming.lei@canonical.com>
On 01/29/15 13:18, Ming Lei wrote:
> The kobject memory inside blk-mq hctx/ctx shouldn't have been freed
> before the kobject is released because driver core can access it freely
> before its release.
>
> We can't do that in all ctx/hctx/mq_kobj's release handler because
> it can be run before blk_cleanup_queue().
>
> Given mq_kobj shouldn't have been introduced, this patch simply moves
> mq's release into blk_release_queue().
Thanks for the quick respin. With these two patches applied my test
passes (SRP SCSI host removal).
Bart.
next prev parent reply other threads:[~2015-01-29 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 12:17 [PATCH 0/2] blk-mq: one revert and one blk-mq kobject fix candidate Ming Lei
2015-01-29 12:17 ` [PATCH 1/2] Revert "blk-mq: fix hctx/ctx kobject use-after-free" Ming Lei
2015-02-03 19:13 ` Stefan Seyfried
2015-02-03 19:14 ` Jens Axboe
2015-02-03 21:50 ` Jens Axboe
2015-02-04 7:43 ` Stefan Seyfried
2015-01-29 12:17 ` [PATCH 2/2] blk-mq: release mq's kobjects in blk_release_queue() Ming Lei
2015-01-29 12:49 ` Bart Van Assche [this message]
2015-01-29 16:31 ` [PATCH 0/2] blk-mq: one revert and one blk-mq kobject fix candidate Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA2C59.2090607@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox