Re: [PATCH 6/9] clocksource: Driver for Conexant Digicolor SoC timer

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 01/29/2015 02:37 PM, Paul Bolle wrote:
> On Thu, 2015-01-29 at 14:08 +0100, Daniel Lezcano wrote:
>> From: Baruch Siach <baruch@tkos.co.il>
>>
>> Add clocksource driver to the Conexant CX92755 SoC, part of the Digicolor SoCs
>> series. Hardware provides 8 timers, A to H. Timer A is dedicated to a future
>> watchdog driver so we don't use it here. Use timer B for sched_clock, and timer
>> C for clock_event.
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>>   drivers/clocksource/Kconfig           |   3 +
>>   drivers/clocksource/Makefile          |   1 +
>>   drivers/clocksource/timer-digicolor.c | 199 ++++++++++++++++++++++++++++++++++
>>   3 files changed, 203 insertions(+)
>>   create mode 100644 drivers/clocksource/timer-digicolor.c
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index a89120b..72a3827 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -18,6 +18,9 @@ config CLKBLD_I8253
>>   config CLKSRC_MMIO
>>   	bool
>>
>> +config DIGICOLOR_TIMER
>> +	bool
>> +
>
> And the select for this symbol (see https://lkml.org/lkml/2015/1/26/360)
> will be provided in a separate patch? Because this patch, by itself,
> won't allow DIGICOLOR_TIMER to be set, will it?

You are right, that should be done in a separate patch. I believe Baruch 
should have done that.

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog