From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbbA2Qb0 (ORCPT ); Thu, 29 Jan 2015 11:31:26 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:45705 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbbA2QbY (ORCPT ); Thu, 29 Jan 2015 11:31:24 -0500 Message-ID: <54CA6050.20705@fb.com> Date: Thu, 29 Jan 2015 08:31:12 -0800 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ming Lei , CC: Christoph Hellwig , Bart Van Assche , Sasha Levin Subject: Re: [PATCH 0/2] blk-mq: one revert and one blk-mq kobject fix candidate References: <1422533847-31726-1-git-send-email-ming.lei@canonical.com> In-Reply-To: <1422533847-31726-1-git-send-email-ming.lei@canonical.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.57.29] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-01-29_05:2015-01-29,2015-01-29,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=0 kscore.compositescore=0 circleOfTrustscore=0 compositescore=0.928997573525383 urlsuspect_oldscore=0.928997573525383 suspectscore=2 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=64355 rbsscore=0.928997573525383 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1501290164 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2015 04:17 AM, Ming Lei wrote: > The 1st patch reverts commit "blk-mq: fix hctx/ctx kobject use-after-free" > (commit 76d697d10769048e) which is wrong and causes scsi regression. > > The 2nd patch is another candidate/approach for fixing hctx/ctx kobject > use-after-free. > > Sorry for causing the mess, and I am happy to see it fixed by either > Bart Van Assche's fix or this patchset, or other better one. Thanks Ming, this looks better... -- Jens Axboe