From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbbA2RVq (ORCPT ); Thu, 29 Jan 2015 12:21:46 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:40424 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754630AbbA2RVo (ORCPT ); Thu, 29 Jan 2015 12:21:44 -0500 Message-ID: <54CA6C20.5090301@ti.com> Date: Thu, 29 Jan 2015 12:21:36 -0500 From: Murali Karicheri User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Arnd Bergmann , "Balbi, Felipe" , CC: David Miller , , , Subject: Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support References: <1421367007-19744-1-git-send-email-m-karicheri2@ti.com> <54C92878.3030207@ti.com> <54C94A0D.9050505@ti.com> <20343006.1NmdQEM9nn@wuerfel> <54C9654C.8030407@ti.com> In-Reply-To: <54C9654C.8030407@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2015 05:40 PM, Murali Karicheri wrote: > + Felipe, Mugunthan for commenting on TI_CPSW, ALE. > --- Cut ------ > >> >> The second problem is where I got stuck myself: cpsw_ale.c (also cpts.c) >> is getting linked into both modules, which is not allowed: It is >> impossible for the kernel to compile these if one driver is a module >> and the other one is not, and any use of KBUILD_MODNAME fails because >> it is unclear what the modname is if the file is compiled once to >> be linked into two drivers. Arnd, I think the solution is to make the cpsw_ale as a module and configured through a Kconfig option. I am working on a fix for this now. Similar fix is required for cpts.o. Currently we are not using this module for Netcp, but soon this will be re-used. I have send a patch that is already applied to net-next removing cpts.o for Netcp. Murali > > I am still looking into this. Both Keystone and TI CPSW driver would > need to use cpsw_ale.o and cpts.o (currently not used, but will need > this later). Not found a solution yet. > > Murali >> >> Arnd > > -- Murali Karicheri Linux Kernel, Texas Instruments