From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758041AbbA2WVQ (ORCPT ); Thu, 29 Jan 2015 17:21:16 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:57755 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbbA2WVP (ORCPT ); Thu, 29 Jan 2015 17:21:15 -0500 Message-ID: <54CAB259.8090704@codeaurora.org> Date: Thu, 29 Jan 2015 14:21:13 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Archit Taneja , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org CC: linux-kernel@vger.kernel.org, agross@codeaurora.org, galak@codeaurora.org Subject: Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x References: <1421419702-17812-1-git-send-email-architt@codeaurora.org> <1421419702-17812-2-git-send-email-architt@codeaurora.org> In-Reply-To: <1421419702-17812-2-git-send-email-architt@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/15 06:48, Archit Taneja wrote: > + > +static struct clk_branch ebi2_aon_clk = { > + .hwcg_reg = 0x3b00, > + .hwcg_bit = 6, It looks like these bits only apply to ebi2_clk, and not ebi2_aon_clk, so these two lines should be dropped. > + .halt_reg = 0x2fcc, > + .halt_bit = 0, > + .clkr = { > + .enable_reg = 0x3b00, > + .enable_mask = BIT(8), > + .hw.init = &(struct clk_init_data){ > + .name = "ebi2_always_on_clk", > + .ops = &clk_branch_ops, > + .flags = CLK_IS_ROOT, > + }, > + }, > +}; > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project