From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759279AbbA3BBW (ORCPT ); Thu, 29 Jan 2015 20:01:22 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:46712 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbbA3BBT (ORCPT ); Thu, 29 Jan 2015 20:01:19 -0500 X-AuditID: cbfee68d-f79296d000004278-f6-54cad7ca145c Message-id: <54CAD7C9.3080003@samsung.com> Date: Fri, 30 Jan 2015 10:00:57 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Robert Baldyga Cc: lee.jones@linaro.org, sameo@linux.intel.com, myungjoo.ham@samsung.com, dmitry.torokhov@gmail.com, cooloney@gmail.com, rpurdie@rpsys.net, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it, paul.gortmaker@windriver.com, sachin.kamat@linaro.org, k.kozlowski@samsung.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v5 3/3] mfd: max8997: change irq names to upper case References: <1415776996-11569-1-git-send-email-r.baldyga@samsung.com> <1415776996-11569-4-git-send-email-r.baldyga@samsung.com> In-reply-to: <1415776996-11569-4-git-send-email-r.baldyga@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42JZI2JSqHvq+qkQg9ZZ2hZLLl5lt5j68Amb xdGdE5ksJj15z2xxeNELRouJKyczW7x+YWhx/+tRRotvVzqYLG5++sZqcXnXHDaLrW/WMVp8 7j3CaHG7cQWbxbW9x5ktHhzeyW6xe9dTVov9nR2MFif/9DJanO5mtTi9u8RB1GPnrLvsHnsm nmTz2LxCy2PTqk42jzvX9rB5zDsZ6LFn/g9Wj74tqxg9ps/7yeTxeZOcx/otW5kCuKO4bFJS czLLUov07RK4MvpfHmEpaJCp6PpzmrmBcaV4FyMnh4SAicTk3oWsELaYxIV769m6GLk4hASW Mkrc2fCWDaZo/ezn7BCJRYwSH99sgnJeM0pc230DrIpXQEti7rVpjCA2i4CqxL6Jj1lAbDag +P4XEDWiAmESK6dfYYGoF5T4MfkemC0CVHPn43x2EJtZ4AOzxN6NmSC2sICHxO8ra1khljUy Srx4uBnsVk4BN4nHnxYxQTToSOxvncYGYctLbF7zlhmkQULgCofE5bZ5LBAXCUh8m3wIyOYA SshKbDrADPGapMTBFTdYJjCKzUJy0ywkY2chGbuAkXkVo2hqQXJBcVJ6kaFecWJucWleul5y fu4mRmDiOP3vWe8OxtsHrA8xCnAwKvHwJjSeDBFiTSwrrsw9xGgKdMVEZinR5HxgesoriTc0 NjOyMDUxNTYytzRTEudVlPoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFxHovwFHWm/KYz yrWXZOaULH9RsVat6BnXgUVGvszRrn+PWKyqdP2anrf3kqj9M50UkYpJ05e/u8pj8qmez+RU 3brcD+k2di1TDV8+3XFj4+1fvOFL7C9/m1NrWyY0bY6Eb5GO5UtuQ5UwGza3R9Y5tVKKWjv2 eO/L+mhvVtZ4WihKYpq68TElluKMREMt5qLiRADi/NLvFwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHKsWRmVeSWpSXmKPExsVy+t9jAd1T10+FGNx5r2Cx5OJVdoupD5+w WRzdOZHJYtKT98wWhxe9YLSYuHIys8XrF4YW978eZbT4dqWDyeLmp2+sFpd3zWGz2PpmHaPF 594jjBa3G1ewWVzbe5zZ4sHhnewWu3c9ZbXY39nBaHHyTy+jxeluVovTu0scRD12zrrL7rFn 4kk2j80rtDw2repk87hzbQ+bx7yTgR575v9g9ejbsorRY/q8n0wenzfJeazfspUpgDuqgdEm IzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+hNJYWyxJxS oFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWNG/8sjLAUNMhVdf04zNzCuFO9i5OSQ EDCRWD/7OTuELSZx4d56ti5GLg4hgUWMEh/fbGKHcF4zSlzbfYMNpIpXQEti7rVpjCA2i4Cq xL6Jj1lAbDag+P4XEDWiAmESK6dfYYGoF5T4MfkemC0CVHPn43ywbcwCH5gl9m7MBLGFBTwk fl9ZywqxrJFR4sXDzawgCU4BN4nHnxYxQTToSOxvncYGYctLbF7zlnkCo8AsJDtmISmbhaRs ASPzKkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzgtPRMegfjqgaLQ4wCHIxKPLwJjSdDhFgT y4orcw8xSnAwK4nw6h87FSLEm5JYWZValB9fVJqTWnyI0RQYBBOZpUST84EpM68k3tDYxMzI 0sjc0MLI2FxJnFfJvi1ESCA9sSQ1OzW1ILUIpo+Jg1OqgdFvWcZvUTbTe05L1eM/KkwVkcl2 509n2DUjXKrv/Ln1dn47HFievW3/9/zQjEMcd77LBZ/bUPFRYX7rs0gj6+W1baGS+18Hvr9o +Z9lrWlf2NZwhqlpRooM+lLNLWeLO8VPhLk/453b/SLX0sznjG1Rh7lIRtNmuaMtzY5Hqho+ 1L23y5ngrsRSnJFoqMVcVJwIACvwVXVhAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, For extcon part, Acked-by: Chanwoo Choi Thanks, Chanwoo Choi On 11/12/2014 04:23 PM, Robert Baldyga wrote: > This patch changes naming convention of MUIC interrupts form CamelCase > to upper case. It makes names more readable and consistent with another > interrupt names in max8997 driver. > > Signed-off-by: Robert Baldyga > Reviewed-by: Krzysztof Kozlowski > > [For the mfd part] > Acked-by: Lee Jones > --- > drivers/extcon/extcon-max8997.c | 32 ++++++++++++++++---------------- > include/linux/mfd/max8997-private.h | 16 ++++++++-------- > 2 files changed, 24 insertions(+), 24 deletions(-) > > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 172dbd6..834b72f 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -46,15 +46,15 @@ struct max8997_muic_irq { > }; > > static struct max8997_muic_irq muic_irqs[] = { > - { MAX8997_MUICIRQ_ADCError, "muic-ADCERROR" }, > - { MAX8997_MUICIRQ_ADCLow, "muic-ADCLOW" }, > - { MAX8997_MUICIRQ_ADC, "muic-ADC" }, > - { MAX8997_MUICIRQ_VBVolt, "muic-VBVOLT" }, > - { MAX8997_MUICIRQ_DBChg, "muic-DBCHG" }, > - { MAX8997_MUICIRQ_DCDTmr, "muic-DCDTMR" }, > - { MAX8997_MUICIRQ_ChgDetRun, "muic-CHGDETRUN" }, > - { MAX8997_MUICIRQ_ChgTyp, "muic-CHGTYP" }, > - { MAX8997_MUICIRQ_OVP, "muic-OVP" }, > + { MAX8997_MUICIRQ_ADCERROR, "MUIC-ADCERROR" }, > + { MAX8997_MUICIRQ_ADCLOW, "MUIC-ADCLOW" }, > + { MAX8997_MUICIRQ_ADC, "MUIC-ADC" }, > + { MAX8997_MUICIRQ_VBVOLT, "MUIC-VBVOLT" }, > + { MAX8997_MUICIRQ_DBCHG, "MUIC-DBCHG" }, > + { MAX8997_MUICIRQ_DCDTMR, "MUIC-DCDTMR" }, > + { MAX8997_MUICIRQ_CHGDETRUN, "MUIC-CHGDETRUN" }, > + { MAX8997_MUICIRQ_CHGTYP, "MUIC-CHGTYP" }, > + { MAX8997_MUICIRQ_OVP, "MUIC-OVP" }, > }; > > /* Define supported cable type */ > @@ -553,17 +553,17 @@ static void max8997_muic_irq_work(struct work_struct *work) > } > > switch (irq_type) { > - case MAX8997_MUICIRQ_ADCError: > - case MAX8997_MUICIRQ_ADCLow: > + case MAX8997_MUICIRQ_ADCERROR: > + case MAX8997_MUICIRQ_ADCLOW: > case MAX8997_MUICIRQ_ADC: > /* Handle all of cable except for charger cable */ > ret = max8997_muic_adc_handler(info); > break; > - case MAX8997_MUICIRQ_VBVolt: > - case MAX8997_MUICIRQ_DBChg: > - case MAX8997_MUICIRQ_DCDTmr: > - case MAX8997_MUICIRQ_ChgDetRun: > - case MAX8997_MUICIRQ_ChgTyp: > + case MAX8997_MUICIRQ_VBVOLT: > + case MAX8997_MUICIRQ_DBCHG: > + case MAX8997_MUICIRQ_DCDTMR: > + case MAX8997_MUICIRQ_CHGDETRUN: > + case MAX8997_MUICIRQ_CHGTYP: > /* Handle charger cable */ > ret = max8997_muic_chg_handler(info); > break; > diff --git a/include/linux/mfd/max8997-private.h b/include/linux/mfd/max8997-private.h > index f42ea22..2817fa6 100644 > --- a/include/linux/mfd/max8997-private.h > +++ b/include/linux/mfd/max8997-private.h > @@ -411,14 +411,14 @@ enum max8997_irq { > > enum max8997_irq_muic { > MAX8997_MUICIRQ_ADC, > - MAX8997_MUICIRQ_ADCLow, > - MAX8997_MUICIRQ_ADCError, > - > - MAX8997_MUICIRQ_ChgTyp, > - MAX8997_MUICIRQ_ChgDetRun, > - MAX8997_MUICIRQ_DCDTmr, > - MAX8997_MUICIRQ_DBChg, > - MAX8997_MUICIRQ_VBVolt, > + MAX8997_MUICIRQ_ADCLOW, > + MAX8997_MUICIRQ_ADCERROR, > + > + MAX8997_MUICIRQ_CHGTYP, > + MAX8997_MUICIRQ_CHGDETRUN, > + MAX8997_MUICIRQ_DCDTMR, > + MAX8997_MUICIRQ_DBCHG, > + MAX8997_MUICIRQ_VBVOLT, > > MAX8997_MUICIRQ_OVP, > >