From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756720AbbA3ISu (ORCPT ); Fri, 30 Jan 2015 03:18:50 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:55564 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939AbbA3ISt (ORCPT ); Fri, 30 Jan 2015 03:18:49 -0500 Message-ID: <54CB3E53.8050307@ti.com> Date: Fri, 30 Jan 2015 13:48:27 +0530 From: Mugunthan V N User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Murali Karicheri , , , , , , , , , , , Subject: Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone References: <1422573351-5603-1-git-send-email-m-karicheri2@ti.com> <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> In-Reply-To: <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 January 2015 04:45 AM, Murali Karicheri wrote: > NetCP on Keystone has cpsw ale function similar to other TI SoCs > and this driver is re-used. To allow both ti cpsw and keystone netcp > to re-use the driver, convert the cpsw ale to a module and configure > it through Kconfig option CONFIG_TI_CPSW_ALE. Currently it is statically > linked to both TI CPSW and NetCP and this causes issues when the above > drivers are built as dynamic modules. This patch addresses this issue > > While at it, fix the Makefile and code to build both netcp_core and > netcp_ethss as dynamic modules. This is needed to support arm allmodconfig. > This also requires exporting of API calls provided by netcp_core so that > both the above can be dynamic modules. > > Signed-off-by: Murali Karicheri Acked-by: Mugunthan V N Will try to test this today/Monday. Regards Mugunthan V N