From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759309AbbA3I5f (ORCPT ); Fri, 30 Jan 2015 03:57:35 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:52585 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbbA3I5d (ORCPT ); Fri, 30 Jan 2015 03:57:33 -0500 Message-ID: <54CB4779.6070107@linaro.org> Date: Fri, 30 Jan 2015 08:57:29 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bjorn Andersson , Liam Girdwood , Mark Brown CC: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] regulator: qcom-rpm: Make it possible to specify supply References: <1422577377-31986-1-git-send-email-bjorn.andersson@sonymobile.com> In-Reply-To: <1422577377-31986-1-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, Thanks for sending this patch.. I almost forgot about this. Shouldn’t we update the DT Bindings with this info? Other than that: Acked-by: Srinivas Kandagatla --srini On 30/01/15 00:22, Bjorn Andersson wrote: > Make it possible to specify the supply of a regulator, through the > vin-supply property in dt. > > Signed-off-by: Bjorn Andersson > --- > drivers/regulator/qcom_rpm-regulator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c > index e3120bf..00c5cc3 100644 > --- a/drivers/regulator/qcom_rpm-regulator.c > +++ b/drivers/regulator/qcom_rpm-regulator.c > @@ -679,6 +679,7 @@ static int rpm_reg_probe(struct platform_device *pdev) > vreg->desc.owner = THIS_MODULE; > vreg->desc.type = REGULATOR_VOLTAGE; > vreg->desc.name = pdev->dev.of_node->name; > + vreg->desc.supply_name = "vin"; > > vreg->rpm = dev_get_drvdata(pdev->dev.parent); > if (!vreg->rpm) { >