Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

Dan Carpenter
2015-01-30T12:10:39Z

On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
> >@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> > ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> > outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> >- i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> >+ inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
> >
> > return IRQ_HANDLED;
> > }
> >
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

Ian, is the inl() really needed? Richard did the conservative thing,
but if we knew we could delete the inl() that would be nice.

regards,
dan carpenter