Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used

Ian Abbott
2015-01-30T10:29:49Z

On 29/01/15 22:34, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/addi_apci_3501.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index a726efc..5961f19 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -267,7 +267,6 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> struct apci3501_private *devpriv = dev->private;
> unsigned int ui_Timer_AOWatchdog;
> unsigned long ul_Command1;
> - int i_temp;
>
> /* Disable Interrupt */
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>
> return IRQ_HANDLED;
> }
>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-