From: Ian Abbott <abbotti@mev.co.uk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bernd Porr <mail@berndporr.me.uk>,
Chase Southwood <chase.southwood@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables that is never used
Date: Fri, 30 Jan 2015 10:52:03 +0000 [thread overview]
Message-ID: <54CB6253.5080906@mev.co.uk> (raw)
In-Reply-To: <1422571809-11476-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 29/01/15 22:50, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/usbduxsigma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c
> index dc19435..185f2d1 100644
> --- a/drivers/staging/comedi/drivers/usbduxsigma.c
> +++ b/drivers/staging/comedi/drivers/usbduxsigma.c
> @@ -215,7 +215,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> struct usbduxsigma_private *devpriv = dev->private;
> struct comedi_async *async = s->async;
> struct comedi_cmd *cmd = &async->cmd;
> - unsigned int dio_state;
> uint32_t val;
> int ret;
> int i;
> @@ -224,9 +223,6 @@ static void usbduxsigma_ai_handle_urb(struct comedi_device *dev,
> if (devpriv->ai_counter == 0) {
> devpriv->ai_counter = devpriv->ai_timer;
>
> - /* get the state of the dio pins to allow external trigger */
> - dio_state = be32_to_cpu(devpriv->in_buf[0]);
> -
> /* get the data from the USB bus and hand it over to comedi */
> for (i = 0; i < cmd->chanlist_len; i++) {
> /* transfer data, note first byte is the DIO state */
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-01-30 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 22:50 [PATCH v2] staging: comedi: drivers: usbduxsigma: Removed variables that is never used Rickard Strandqvist
2015-01-30 10:52 ` Ian Abbott [this message]
2015-01-30 11:19 ` Bernd Porr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB6253.5080906@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@berndporr.me.uk \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox