From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: david.vrabel@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>,
boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read
Date: Fri, 30 Jan 2015 13:23:27 +0100 [thread overview]
Message-ID: <54CB77BF.9010300@suse.com> (raw)
In-Reply-To: <54CB7D52020000780005B405@mail.emea.novell.com>
On 01/30/2015 12:47 PM, Jan Beulich wrote:
>>>> On 30.01.15 at 12:21, <JGross@suse.com> wrote:
>> @@ -734,11 +734,11 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info)
>> if (!pending_req)
>> return 1;
>>
>> - ring_req = RING_GET_REQUEST(ring, rc);
>> + memcpy(&ring_req, RING_GET_REQUEST(ring, rc), sizeof(ring_req));
>
> I'd recommend the type safe *ring_req = *RING_GET_REQUEST(ring, rc)
> here.
I think I'll use ring_req = *RING_GET_REQUEST(ring, rc) :-)
>
>> ring->req_cons = ++rc;
>>
>> - act = ring_req->act;
>> - err = prepare_pending_reqs(info, ring_req, pending_req);
>> + act = ring_req.act;
>
> Is this helper variable then still needed?
No, you're right. Will delete it.
Juergen
next prev parent reply other threads:[~2015-01-30 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 11:21 [PATCH 0/3] xen: pvscsi: avoid race, support suspend/resume Juergen Gross
2015-01-30 11:21 ` [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read Juergen Gross
2015-01-30 11:47 ` [Xen-devel] " Jan Beulich
2015-01-30 12:23 ` Juergen Gross [this message]
2015-01-30 11:21 ` [PATCH 2/3] xen: scsiback: add LUN of restored domain Juergen Gross
2015-01-30 11:21 ` [PATCH 3/3] xen: support suspend/resume in pvscsi frontend Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB77BF.9010300@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox