From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761931AbbA3MXb (ORCPT ); Fri, 30 Jan 2015 07:23:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58175 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756110AbbA3MXa (ORCPT ); Fri, 30 Jan 2015 07:23:30 -0500 Message-ID: <54CB77BF.9010300@suse.com> Date: Fri, 30 Jan 2015 13:23:27 +0100 From: Juergen Gross User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jan Beulich CC: david.vrabel@citrix.com, xen-devel , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH 1/3] xen: mark pvscsi frontend request consumed only after last read References: <1422616865-13573-1-git-send-email-jgross@suse.com> <1422616865-13573-2-git-send-email-jgross@suse.com> <54CB7D52020000780005B405@mail.emea.novell.com> In-Reply-To: <54CB7D52020000780005B405@mail.emea.novell.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2015 12:47 PM, Jan Beulich wrote: >>>> On 30.01.15 at 12:21, wrote: >> @@ -734,11 +734,11 @@ static int scsiback_do_cmd_fn(struct vscsibk_info *info) >> if (!pending_req) >> return 1; >> >> - ring_req = RING_GET_REQUEST(ring, rc); >> + memcpy(&ring_req, RING_GET_REQUEST(ring, rc), sizeof(ring_req)); > > I'd recommend the type safe *ring_req = *RING_GET_REQUEST(ring, rc) > here. I think I'll use ring_req = *RING_GET_REQUEST(ring, rc) :-) > >> ring->req_cons = ++rc; >> >> - act = ring_req->act; >> - err = prepare_pending_reqs(info, ring_req, pending_req); >> + act = ring_req.act; > > Is this helper variable then still needed? No, you're right. Will delete it. Juergen