From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762023AbbA3M5d (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 07:57:33 -0500
Received: from outbound-smtp02.blacknight.com ([81.17.249.8]:42324 "EHLO
	outbound-smtp02.blacknight.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751972AbbA3M5c (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 07:57:32 -0500
Message-ID: <54CB7FB9.3010806@nexus-software.ie>
Date: Fri, 30 Jan 2015 12:57:29 +0000
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        "dvhart@infradead.org" <dvhart@infradead.org>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: [PATCH v7 1/2] x86: Add Isolated Memory Regions for Quark
 X1000
References: <1422587139-32139-1-git-send-email-pure.logic@nexus-software.ie>	<1422587139-32139-2-git-send-email-pure.logic@nexus-software.ie>	<CAHp75VfF_ybFLsVpfLGayoSi_shjXsmvsF52o2-L4W0hZ7+HQw@mail.gmail.com> <CAHp75VecMbiY3-KxNa0OzkUfLtH0TtPGik-eO-KkyQjHDcG3kQ@mail.gmail.com> <54CB7F5F.2070308@nexus-software.ie>
In-Reply-To: <54CB7F5F.2070308@nexus-software.ie>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30/01/15 12:55, Bryan O'Donoghue wrote:
> Oops.
>
> Hit reply not reply-all

On 30/01/15 12:03, Andy Shevchenko wrote:
 >> +               return -ENOMEM;
 >
 > When CONFIG_DEBUGFS=n, you will get error pointer here, which is not 
NULL.
 >
 > So, the proper check is
 > if (IS_ERR())
 >   return PTR_ERR();
 > if (!file)
 >   return -ENOMEM;

Yeah I saw that. Also saw that most other code doesn't bother trapping
those return values - so skipped it.
No issue adding.

 >
 >> +               } else {
 >> +                       reg = i;
 >
 > Do we go always through all IMRs and choose the last one?
 > If no, break is missed here.

Yep - we always choose the last one.


 >> +               }
 >> +       }
 >> +
 >> +       /* Error out if we have no free IMR entries. */
 >> +       if (reg == -1) {
 >> +               ret = -ENODEV;
 >
 > -ENOMEM ? Like you said there is no *free* IMR.

OK

 >> + * imr_remove_range(0, size, base); delete IMR at index 0 base/size 
ignored.
 >> + * imr_remove_range(-1, base, size); delete IMR from base to base+size.
 >
 > (size, base) or (base, size) ?

base, size that's a documentation typo :)

 >> +
 >> +       ret = imr_check_params(base, size);
 >> +       if (ret == -EINVAL || (ret == -ENOMEM && reg == -1))
 >
 > reg base size (0 correct, 1 wrong):
 >
 > 0 0 0 — which should be used? what is the priority?
 > 0 x 1 — index
 > 0 1 x — index
 > 1 0 0 — address
 > 1 0 1 — an error
 > 1 1 1 — an error
 >
 > Thus, could it be simpler? Like
 > if (reg < 0 && ret) ?

ret will be EINVAL for unaligned base or size
ret will be ENOMEM when reg == -1 and size == 0

I could probably write it like this to make it clearer
(ret == -EINVAL || (reg == -1 && size == 0)
	return -EINVAL;

traps unaligned input - for address range tear-down
traps zero sized - for address range tear-down

Allows index based teardown i.e. reg >= 0

 > if (ret)
 >
 >> +               pr_warn("debugfs register failed!\n");
 >
 > Do we actually need this? Or move it to debug level.

It was your suggestion @ a previous review ....

 > Here is the mix of kernel levels. What about to align them?
 >
 > For example I doubt we need to distinguish messages by level:
 >
 > pr_info();
 > vprintk(KERN_INFO fmt, …);

OK fine.