From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762258AbbA3M77 (ORCPT ); Fri, 30 Jan 2015 07:59:59 -0500 Received: from mail-qg0-f42.google.com ([209.85.192.42]:45205 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbbA3M76 (ORCPT ); Fri, 30 Jan 2015 07:59:58 -0500 Message-ID: <54CB8047.3040300@hurleysoftware.com> Date: Fri, 30 Jan 2015 07:59:51 -0500 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dan Carpenter CC: Rickard Strandqvist , Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, Erik Arfvidson , Greg Kroah-Hartman , sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: virtpci: virtpci: Fix for possible null pointer dereference References: <1422557426-3929-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150130123942.GY6456@mwanda> In-Reply-To: <20150130123942.GY6456@mwanda> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2015 07:39 AM, Dan Carpenter wrote: > Btw, if you have the smatch cross function database set up then you can > figure out this sort of thing by using: > > $ smdb.py virtpci_driver_attr_store > > It says that: > > fs/sysfs/file.c | sysfs_kf_write | (struct sysfs_ops)->store | PARAM_VALUE | 0 | $ | 4096-2117777777777777777 > > So this is called from sysfs_kf_write() and parameter zero is a valid > pointer. Hi Dan, This would be a good topic for an LWN.net article. Regards, Peter Hurley