From: Ian Abbott <abbotti@mev.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Fred Akers <knivey@botops.net>
Subject: Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used
Date: Fri, 30 Jan 2015 13:16:20 +0000 [thread overview]
Message-ID: <54CB8424.4060407@mev.co.uk> (raw)
In-Reply-To: <20150130121027.GX6456@mwanda>
On 30/01/15 12:10, Dan Carpenter wrote:
> On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
>>> @@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
>>> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
>>> ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
>>> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
>>> - i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
>>> + inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
>>>
>>> return IRQ_HANDLED;
>>> }
>>>
>>
>> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
>
> Ian, is the inl() really needed? Richard did the conservative thing,
> but if we knew we could delete the inl() that would be nice.
I'm not sure if it's really needed, but it is part of some watchdog
functionality, so I thought it best to leave it alone.
Hartley might know if it's needed.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-01-30 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 22:34 [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed variables that is never used Rickard Strandqvist
2015-01-30 10:29 ` Ian Abbott
2015-01-30 12:10 ` Dan Carpenter
2015-01-30 13:16 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB8424.4060407@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=knivey@botops.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox