Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

Murali Karicheri
2015-01-30T15:25:58Z

On 01/30/2015 04:56 AM, Mugunthan V N wrote:
> On Friday 30 January 2015 01:48 PM, Mugunthan V N wrote:
>> On Friday 30 January 2015 04:45 AM, Murali Karicheri wrote:
>>> NetCP on Keystone has cpsw ale function similar to other TI SoCs
>>> and this driver is re-used. To allow both ti cpsw and keystone netcp
>>> to re-use the driver, convert the cpsw ale to a module and configure
>>> it through Kconfig option CONFIG_TI_CPSW_ALE. Currently it is statically
>>> linked to both TI CPSW and NetCP and this causes issues when the above
>>> drivers are built as dynamic modules. This patch addresses this issue
>>>
>>> While at it, fix the Makefile and code to build both netcp_core and
>>> netcp_ethss as dynamic modules. This is needed to support arm allmodconfig.
>>> This also requires exporting of API calls provided by netcp_core so that
>>> both the above can be dynamic modules.
>>>
>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>>
>> Acked-by: Mugunthan V N<mugunthanvnm@ti.com>
>>
>> Will try to test this today/Monday.
>>
>>
>
> I have tested this on DRA7 platform and passed tested ping.
>
> Tested-by: Mugunthan V N<mugunthanvnm@ti.com>
Mugunthan,

Thanks for testing this.

Murali
>
> Regards
> Mugunthan V N

--
Murali Karicheri
Linux Kernel, Texas Instruments