From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762842AbbA3SGy (ORCPT ); Fri, 30 Jan 2015 13:06:54 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:55716 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754073AbbA3SGl (ORCPT ); Fri, 30 Jan 2015 13:06:41 -0500 Message-ID: <54CBC82D.2050003@linaro.org> Date: Fri, 30 Jan 2015 18:06:37 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bjorn Andersson CC: Mike Turquette , Stephen Boyd , Rob Herring , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm , edubezval@gmail.com, nrajan@codeaurora.com, Arnd Bergmann Subject: Re: [PATCH v2 1/2] clk: qcom: gcc-msm8960: add child devices support. References: <1422613004-29802-1-git-send-email-srinivas.kandagatla@linaro.org> <1422613060-29886-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/15 16:57, Bjorn Andersson wrote: > On Fri, Jan 30, 2015 at 2:17 AM, Srinivas Kandagatla > wrote: >> This patch adds support to add child devices to gcc as some of the >> registers mapped by gcc are used by drivers like thermal sensors. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/clk/qcom/gcc-msm8960.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c >> index 0cd3e26..3ba77c5 100644 >> --- a/drivers/clk/qcom/gcc-msm8960.c >> +++ b/drivers/clk/qcom/gcc-msm8960.c >> @@ -15,6 +15,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -3658,6 +3659,7 @@ static int gcc_msm8960_probe(struct platform_device *pdev) >> struct clk *clk; >> struct device *dev = &pdev->dev; >> const struct of_device_id *match; >> + int ret; >> >> match = of_match_device(gcc_msm8960_match_table, &pdev->dev); >> if (!match) >> @@ -3677,12 +3679,18 @@ static int gcc_msm8960_probe(struct platform_device *pdev) >> if (IS_ERR(clk)) >> return PTR_ERR(clk); >> >> - return qcom_cc_probe(pdev, match->data); >> + ret = qcom_cc_probe(pdev, match->data); >> + if (ret) >> + return ret; >> + >> + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > > How about calling of_syscon_register() instead? That would give us a > handle to a regmap that can be consumed in e.g. the thermal driver. Two things: - Are you sure, this looks like of_syscon_register() is a static function - gcc node would be required to add "syscon" compatible Unless am missing some patches, Am not sure if going via syscon is right thing here? Stephen Any comments? --srini > > I think this use case is exactly why that was introduced. > > Regards, > Bjorn >