From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762946AbbA3SUO (ORCPT ); Fri, 30 Jan 2015 13:20:14 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35655 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbbA3SUM (ORCPT ); Fri, 30 Jan 2015 13:20:12 -0500 Message-ID: <54CBCB11.401@zytor.com> Date: Fri, 30 Jan 2015 10:18:57 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Feng Wu , tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, gleb@kernel.org, pbonzini@redhat.com, dwmw2@infradead.org, joro@8bytes.org, alex.williamson@redhat.com, jiang.liu@linux.intel.com CC: eric.auger@linaro.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kvm@vger.kernel.org Subject: Re: [v3 21/26] x86, irq: Define a global vector for VT-d Posted-Interrupts References: <1418397300-10870-1-git-send-email-feng.wu@intel.com> <1418397300-10870-22-git-send-email-feng.wu@intel.com> In-Reply-To: <1418397300-10870-22-git-send-email-feng.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2014 07:14 AM, Feng Wu wrote: > Currently, we use a global vector as the Posted-Interrupts > Notification Event for all the vCPUs in the system. We need > to introduce another global vector for VT-d Posted-Interrtups, > which will be used to wakeup the sleep vCPU when an external > interrupt from a direct-assigned device happens for that vCPU. > > Signed-off-by: Feng Wu > > #ifdef CONFIG_HAVE_KVM > +void (*wakeup_handler_callback)(void) = NULL; > +EXPORT_SYMBOL_GPL(wakeup_handler_callback); > + Stylistic nitpick: we generally don't explicitly initialize global/static pointer variables to NULL (that happens automatically anyway.) Other than that, Acked-by: H. Peter Anvin