From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763293AbbA3Vhy (ORCPT ); Fri, 30 Jan 2015 16:37:54 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:43120 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763264AbbA3Vhw (ORCPT ); Fri, 30 Jan 2015 16:37:52 -0500 Message-ID: <54CBF9AE.6060902@codeaurora.org> Date: Fri, 30 Jan 2015 13:37:50 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kumar Gala , Andy Gross CC: linux-arm-msm , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "open list:OPEN FIRMWARE AND..." , Bjorn Andersson , linux-soc@vger.kernel.org Subject: Re: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing References: <1422599135-5588-1-git-send-email-agross@codeaurora.org> <1422599135-5588-2-git-send-email-agross@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/15 08:32, Kumar Gala wrote: > On Jan 30, 2015, at 12:25 AM, Andy Gross wrote: > >> Required properties if child node exists: >> - #address-cells: Must be 1 >> - #size-cells: Must be 1 >> - ranges: Must be present >> >> +Note: Each GSBI should have an alias correctly numbered in "aliases" node. >> + >> Properties for children: >> >> A GSBI controller node can contain 0 or more child nodes representing serial >> @@ -37,6 +41,10 @@ Example for APQ8064: >> >> #include >> >> + aliases { >> + gsbi4 = <&gsbi4>; >> + }; > You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi’s for this purpose. > I thought cell-index was "deprecated" and referred more to things like enumerating all the devices on a bus by assigning them a unique ID. Aliases, on the other hand, allow us to enumerate a subset of devices that share the same bus with other devices of different types. For example, how would I know that a device is gsbi1 vs serial1 if they both used cell-index and they both had the same parent node? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project