From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761071AbbA3Xst (ORCPT ); Fri, 30 Jan 2015 18:48:49 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:52362 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbbA3Xsr (ORCPT ); Fri, 30 Jan 2015 18:48:47 -0500 Message-ID: <54CC185E.9010007@codeaurora.org> Date: Fri, 30 Jan 2015 15:48:46 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Michael Turquette , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] clk: remove clk-private.h References: <1422653113-32688-1-git-send-email-mturquette@linaro.org> <1422653113-32688-4-git-send-email-mturquette@linaro.org> In-Reply-To: <1422653113-32688-4-git-send-email-mturquette@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/15 13:25, Michael Turquette wrote: > Private clock framework data structures should be private, surprisingly. > > Now that all platforms and drivers have been updated to remove static > initializations of struct clk and struct clk_core objects and all > references to clk-private.h have been removed we can move the > definitions of these structures into drivers/clk/clk.c and delete the > header. > > Additionally the ugly DEFINE_CLK macros have been removed. Those were > used for static definitions of struct clk objects. That practice is no > longer allowed. > > Signed-off-by: Michael Turquette This is great! Reviewed-by: Stephen Boyd given the minor comment below. > - * Returns 0 on success, otherwise an error code. > - */ > -int __clk_init(struct device *dev, struct clk *clk); Shouldn't __clk_init become static now in clk.c? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project