From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761970AbbAaAb3 (ORCPT ); Fri, 30 Jan 2015 19:31:29 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:37034 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819AbbAaAbZ (ORCPT ); Fri, 30 Jan 2015 19:31:25 -0500 Message-ID: <54CC224D.80201@huawei.com> Date: Sat, 31 Jan 2015 08:31:09 +0800 From: Zefan Li User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Jason Low CC: Tejun Heo , Peter Zijlstra , , , , , , Subject: Re: [PATCH v2] cpuset: Fix cpuset sched_relax_domain_level References: <1422644094.3365.7.camel@j-VirtualBox> In-Reply-To: <1422644094.3365.7.camel@j-VirtualBox> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.18.230] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/1/31 2:54, Jason Low wrote: > The cpuset.sched_relax_domain_level can control how far we do > immediate load balancing on a system. However, it was found on recent > kernels that echo'ing a value into cpuset.sched_relax_domain_level > did not reduce any immediate load balancing. > > The reason this occurred was because the update_domain_attr_tree() traversal > did not update for the "top_cpuset". This resulted in nothing being changed > when modifying the sched_relax_domain_level parameter. > > This patch is able to address that problem by having update_domain_attr_tree() > allow updates for the root in the cpuset traversal. > > Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()") > Cc: # 3.9+ > Signed-off-by: Jason Low Acked-by: Zefan Li > --- > kernel/cpuset.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/kernel/cpuset.c b/kernel/cpuset.c > index 64b257f..b589e57 100644 > --- a/kernel/cpuset.c > +++ b/kernel/cpuset.c > @@ -548,9 +548,6 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr, > > rcu_read_lock(); > cpuset_for_each_descendant_pre(cp, pos_css, root_cs) { > - if (cp == root_cs) > - continue; > - > /* skip the whole subtree if @cp doesn't have any CPU */ > if (cpumask_empty(cp->cpus_allowed)) { > pos_css = css_rightmost_descendant(pos_css); >