From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754421AbbAaQey (ORCPT ); Sat, 31 Jan 2015 11:34:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44987 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbbAaQew (ORCPT ); Sat, 31 Jan 2015 11:34:52 -0500 Message-ID: <54CD0423.7010402@redhat.com> Date: Sat, 31 Jan 2015 17:34:43 +0100 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Guenter Roeck CC: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT Subject: Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported References: <1422721938-1542-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1422721938-1542-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/31/2015 05:32 PM, Guenter Roeck wrote: > of_platform_device_create does not exist if OF_ADDRESS is not configured, > so limit its use accordingly. > > Without this fix, the sparc64:allmodconfig build fails with > > ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! > > Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") > Cc: Gregory CLEMENT > Signed-off-by: Guenter Roeck Looks good, Acked-by: Hans de Goede Regards, Hans > --- > Applies to -next. > > drivers/ata/libahci_platform.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index 077c7a2..de9a5dc 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -434,7 +434,8 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev) > } > mask_port_map |= BIT(port); > > - of_platform_device_create(child, NULL, NULL); > + if (IS_ENABLED(CONFIG_OF_ADDRESS)) > + of_platform_device_create(child, NULL, NULL); > > port_dev = of_find_device_by_node(child); > >