From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754468AbbAaQxm (ORCPT ); Sat, 31 Jan 2015 11:53:42 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:55682 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752095AbbAaQxl (ORCPT ); Sat, 31 Jan 2015 11:53:41 -0500 Message-ID: <54CD0890.7050800@roeck-us.net> Date: Sat, 31 Jan 2015 08:53:36 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tejun Heo CC: Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT Subject: Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported References: <1422721938-1542-1-git-send-email-linux@roeck-us.net> <20150131164517.GB3088@htj.dyndns.org> In-Reply-To: <20150131164517.GB3088@htj.dyndns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54CD0894.00F8,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 08:45 AM, Tejun Heo wrote: > On Sat, Jan 31, 2015 at 08:32:18AM -0800, Guenter Roeck wrote: >> of_platform_device_create does not exist if OF_ADDRESS is not configured, >> so limit its use accordingly. >> >> Without this fix, the sparc64:allmodconfig build fails with >> >> ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! >> >> Fixes: c7d7ddee7e24 ("ata: libahci: Allow using multiple regulators") >> Cc: Gregory CLEMENT >> Signed-off-by: Guenter Roeck >> --- >> Applies to -next. >> >> drivers/ata/libahci_platform.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c >> index 077c7a2..de9a5dc 100644 >> --- a/drivers/ata/libahci_platform.c >> +++ b/drivers/ata/libahci_platform.c >> @@ -434,7 +434,8 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev) >> } >> mask_port_map |= BIT(port); >> >> - of_platform_device_create(child, NULL, NULL); >> + if (IS_ENABLED(CONFIG_OF_ADDRESS)) >> + of_platform_device_create(child, NULL, NULL); > > This is weird. Please either define a proper dummy version of the > function in the appropriate header file or take out the whole > invocation section w/ #ifndef. The above is a weird hybrid where both > the declaration and the user here are doing things half-way. Please > don't do this in other places either. > I agree, it is weird, as is the whole "all API functions associated with OF_ADDRESS are handled differently on sparc" thing. But that is neither new nor something I can fix. No problem, I'll resubmit with #ifndef. Guenter