From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755509AbbAaReE (ORCPT ); Sat, 31 Jan 2015 12:34:04 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:59418 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754912AbbAaReB (ORCPT ); Sat, 31 Jan 2015 12:34:01 -0500 Message-ID: <54CD1203.6010400@roeck-us.net> Date: Sat, 31 Jan 2015 09:33:55 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Tejun Heo CC: Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Gregory CLEMENT Subject: Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported References: <1422721938-1542-1-git-send-email-linux@roeck-us.net> <20150131164517.GB3088@htj.dyndns.org> <54CD0890.7050800@roeck-us.net> <20150131170812.GC3088@htj.dyndns.org> In-Reply-To: <20150131170812.GC3088@htj.dyndns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020203.54CD1208.00C3,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 09:08 AM, Tejun Heo wrote: > On Sat, Jan 31, 2015 at 08:53:36AM -0800, Guenter Roeck wrote: >> I agree, it is weird, as is the whole "all API functions associated >> with OF_ADDRESS are handled differently on sparc" thing. But that >> is neither new nor something I can fix. > > Out of curiousity, why isn't the header file doing the following? > > #ifdef CONFIG_OF_ADDRESS > > void of_platform_device_create(blah); > ... > > #else > > static inline void of_platform_device_create(blah) > { > } > > #endif > Maybe it is to ensure that the callers realize that the code won't always work as intended, but I don't really know. It is kind of annoying, though, since the resulting compile errors show up on a regular basis. Mostly they are resolved by disabling the affected code for sparc, but obviously that won't work here. AFAIK this only affects sparc, all other architectures support OF_ADDRESS. There was some discussion to get rid of OF_ADDRESS at some point, so there is hope that this will get resolved. Until then all we can do is to put in bandages. Guenter