From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754027AbbAaRlJ (ORCPT ); Sat, 31 Jan 2015 12:41:09 -0500 Received: from mail-oi0-f44.google.com ([209.85.218.44]:58839 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752710AbbAaRlH (ORCPT ); Sat, 31 Jan 2015 12:41:07 -0500 Message-ID: <54CD13B0.9030009@lwfinger.net> Date: Sat, 31 Jan 2015 11:41:04 -0600 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dan Carpenter , Rickard Strandqvist , Greg Kroah-Hartman CC: devel@driverdev.osuosl.org, Jia He , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used References: <1422715533-915-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150131161957.GF6456@mwanda> In-Reply-To: <20150131161957.GF6456@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/31/2015 10:19 AM, Dan Carpenter wrote: > On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: >> while (phead != plist) { >> - psta = container_of(plist, struct sta_info , list); >> + container_of(plist, struct sta_info, list); > > > Argh!!! No. > > For this one, I didn't need an context to see that it was wrong, so I > accidentally reviewed it instead of just marking it as read. > Dan, This guy does not have a brain - he only knows how to run cppcheck. You cannot expect him to think about what he does. In addition, he does not have any of the hardware that uses the drivers he is mangling. He can only test that it builds correctly. Do not bother to ever review anything he sends. Earlier this month, he submitted a set of patches that impacted routines that I was working on. I asked him to hold those until I was finished to avoid conflicts. Guess what? The same set was resubmitted 4 days later!! He was told that sets of patches were supposed to be submitted with a [PATCH X/Y] structure, but he has ignored that suggestion, thus there is no way to send an overall NACK. @Greg: Please put this guy on your permanent blacklist. It takes too much time to read and respond to his multiple posts. Kalle has already done that for wireless. Larry