[PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Rickard Strandqvist]

Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index dc9d0dd..1e737ed 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -149,7 +149,6 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int
 static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
 {
 	struct list_head *plist, *phead;
-	struct sta_info *psta = NULL;
 
 
 	spin_lock_bh(&pstapriv->sta_hash_lock);
@@ -158,7 +157,7 @@ static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
 	plist = phead->next;
 
 	while (phead != plist) {
-		psta = container_of(plist, struct sta_info , list);
+		container_of(plist, struct sta_info, list);
 		plist = plist->next;
 	}
 
-- 
1.7.10.4

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Dan Carpenter]

On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
>  	while (phead != plist) {
> -		psta = container_of(plist, struct sta_info , list);
> +		container_of(plist, struct sta_info, list);


Argh!!!  No.

For this one, I didn't need an context to see that it was wrong, so I
accidentally reviewed it instead of just marking it as read.

regards,
dan carpenter

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Larry Finger]

On 01/31/2015 10:19 AM, Dan Carpenter wrote:
> On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
>>   	while (phead != plist) {
>> -		psta = container_of(plist, struct sta_info , list);
>> +		container_of(plist, struct sta_info, list);
>
>
> Argh!!!  No.
>
> For this one, I didn't need an context to see that it was wrong, so I
> accidentally reviewed it instead of just marking it as read.
>

Dan,

This guy does not have a brain - he only knows how to run cppcheck. You cannot 
expect him to think about what he does. In addition, he does not have any of the 
hardware that uses the drivers he is mangling. He can only test that it builds 
correctly. Do not bother to ever review anything he sends.

Earlier this month, he submitted a set of patches that impacted routines that I 
was working on. I asked him to hold those until I was finished to avoid 
conflicts. Guess what? The same set was resubmitted 4 days later!!

He was told that sets of patches were supposed to be submitted with a [PATCH 
X/Y] structure, but he has ignored that suggestion, thus there is no way to send 
an overall NACK.

@Greg: Please put this guy on your permanent blacklist. It takes too much time 
to read and respond to his multiple posts. Kalle has already done that for wireless.

Larry

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Greg Kroah-Hartman]

On Sat, Jan 31, 2015 at 11:41:04AM -0600, Larry Finger wrote:
> On 01/31/2015 10:19 AM, Dan Carpenter wrote:
> >On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
> >>  	while (phead != plist) {
> >>-		psta = container_of(plist, struct sta_info , list);
> >>+		container_of(plist, struct sta_info, list);
> >
> >
> >Argh!!!  No.
> >
> >For this one, I didn't need an context to see that it was wrong, so I
> >accidentally reviewed it instead of just marking it as read.
> >
> 
> Dan,
> 
> This guy does not have a brain - he only knows how to run cppcheck. You
> cannot expect him to think about what he does. In addition, he does not have
> any of the hardware that uses the drivers he is mangling. He can only test
> that it builds correctly. Do not bother to ever review anything he sends.
> 
> Earlier this month, he submitted a set of patches that impacted routines
> that I was working on. I asked him to hold those until I was finished to
> avoid conflicts. Guess what? The same set was resubmitted 4 days later!!
> 
> He was told that sets of patches were supposed to be submitted with a [PATCH
> X/Y] structure, but he has ignored that suggestion, thus there is no way to
> send an overall NACK.
> 
> @Greg: Please put this guy on your permanent blacklist. It takes too much
> time to read and respond to his multiple posts. Kalle has already done that
> for wireless.

I've now dropped all patches he recently sent me.

thanks,

greg k-h

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

[Greg Kroah-Hartman]

On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index dc9d0dd..1e737ed 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -149,7 +149,6 @@ inline struct sta_info *rtw_get_stainfo_by_offset(struct sta_priv *stapriv, int
>  static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
>  {
>  	struct list_head *plist, *phead;
> -	struct sta_info *psta = NULL;
>  
>  
>  	spin_lock_bh(&pstapriv->sta_hash_lock);
> @@ -158,7 +157,7 @@ static void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)
>  	plist = phead->next;
>  
>  	while (phead != plist) {
> -		psta = container_of(plist, struct sta_info , list);
> +		container_of(plist, struct sta_info, list);

How did this patch even compile?

{sigh}