From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754751AbbBBJli (ORCPT ); Mon, 2 Feb 2015 04:41:38 -0500 Received: from smtp-out-232.synserver.de ([212.40.185.232]:1100 "EHLO smtp-out-230.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753097AbbBBJlh (ORCPT ); Mon, 2 Feb 2015 04:41:37 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 30941 Message-ID: <54CF464F.9000306@metafoo.de> Date: Mon, 02 Feb 2015 10:41:35 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling References: <1422866258-10517-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1422866258-10517-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, rather > than introducing a new variable the wait_for_completion_timeout is moved > into the if condition as the return value is only used to detect timeout. But the return value is bound by the timeout parameter and we know that fits into a int. And I really dont like moving the function call into the if condition, so unless there is some additional explanation why this is necessary and should be done I'm inclined to nack this. > > Signed-off-by: Nicholas Mc Guire > --- > > Aside from the fixup of the wait_for_completion_timeout handling > a minor coding style issue in the else branch was fixed - the {} is > not needed for the one-line body. If one of the branches of a conditional statement has braces the other branches should also have braces. This is documented in Documentation/CodingStyle.