Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

Varka Bhadram
2015-01-29T14:15:32Z

On Thu, Jan 29, 2015 at 7:07 PM, Javier Martinez Canillas
<javier.martinez@collabora.co.uk> wrote:
> From: Bill Richardson <wfrichar@chromium.org>
>
> Chromebooks have an Embedded Controller (EC) that is used to
> implement various functions such as keyboard, power and battery.
>
> The AP can communicate with the EC through different bus types
> such as I2C, SPI or LPC.
>
> The cros_ec mfd driver is then composed of a core driver that
> register the sub-devices as mfd cells and provide a high level
> communication interface that is used by the rest of the kernel
> and bus specific interfaces modules.
>
> Each connection method then has its own driver, which register
> with the EC driver interface-agnostic interface.
>
> Currently, there are drivers to communicate with the EC over
> I2C and SPI and this driver adds support for LPC.
>
> Signed-off-by: Bill Richardson <wfrichar@chromium.org>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Changes since v3:
> - Rename MYNAME to DRV_NAME
> - Use devm_request_region() instead of request_region.
> Suggested by Varka Bhadram.
> - Remove release_region from cleanup handle logic by using devres API.
> Suggested by Varka Bhadram.
> - Use {dev,pr}_err() instead of {dev,pr}_warn() to log errors.
>

Addressed all of my comments... Thanks

Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>

--
Regards,
Varka Bhadram.