From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754850AbbBBQZY (ORCPT ); Mon, 2 Feb 2015 11:25:24 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64489 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754420AbbBBQZV (ORCPT ); Mon, 2 Feb 2015 11:25:21 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-53-54cfa45d98c3 Message-id: <54CFA4ED.3050902@samsung.com> Date: Mon, 02 Feb 2015 17:25:17 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: cw00.choi@samsung.com Cc: Tomasz Figa , Mike Turquette , Kukjin Kim , "pankaj.dubey@samsung.com" , sangbae90.lee@samsung.com, "inki.dae@samsung.com" , "chanho61.park@samsung.com" , Seung-Woo Kim , linux-samsung-soc , linux-kernel Subject: Re: [PATCH v4 01/13] clk: samsung: exynos5433: Add binding document for Exynos5433 clock domains References: <1422882074-19758-1-git-send-email-cw00.choi@samsung.com> <1422882074-19758-2-git-send-email-cw00.choi@samsung.com> <54CF81DE.3010902@samsung.com> <54CF84D8.7070208@samsung.com> <54CF8C75.7000104@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xK7qxS86HGHyaKW1xeb+2xfUvz1kt Jt2fwGLR//g1s8XlXXPYLGac38dk8XTCRTaLRVu/sFsc/3SQxWLG5JdsFqt2/WF04PbYOesu u8emVZ1sHneu7WHz6NuyitHj8ya5ANYoLpuU1JzMstQifbsEroz//W9ZClbwVaz4dYSlgXEO VxcjJ4eEgInE1pU7WSFsMYkL99azgdhCAksZJQ58kO5i5AKyPzFKNByfCFTEwcEroCXRekQc pIZFQFVi2cpmdhCbTcBQovdoHyOILSoQIXHy7h6wOK+AoMSPyfdYQFpFBCQlWvaZgYxkFjjE LHFmwjqwemGBbIkD32exQ+xaySSxeu9NFpAEp0CwxJJvZ5lBmpkF1CWmTMkFCTMLyEtsXvOW eQKjwCwkK2YhVM1CUrWAkXkVo2hqaXJBcVJ6rqFecWJucWleul5yfu4mRkgcfNnBuPiY1SFG AQ5GJR7eB9znQoRYE8uKK3MPMUpwMCuJ8PpNOx8ixJuSWFmVWpQfX1Sak1p8iJGJg1OqgdGg xPNPJIPeMe6nzjW/K26K97p3cf0TiLr1SoxjrXev5P7Tb3Ur6nk5np+5w71WkaPbQkpSgnHp K7bLD5ZzPX4WMSe4t6fDJiBWT2KW+Zvsux11nrYzZuV3PY+W2FN6zaYzNX6a24cZNixf5ldc qH3+OmpubPn046o1OW4X2s9JGB5dt3VTsBJLcUaioRZzUXEiAMe/Bk1hAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 02/02/15 16:51, Chanwoo Choi wrote: > On Mon, Feb 2, 2015 at 11:40 PM, Sylwester Nawrocki > wrote: >> > On 02/02/15 15:08, Chanwoo Choi wrote: >> > >>> >> OK, I'll add more following information: >>> >> I'll send only patch1 with following information. >>> >> >>> >> + - clocks: list of clock identifiers which are fed as the input to >>> >> + the given clock controller. Please refer the next section to >>> >> + find the input clocks for a given controller. >>> >> + - clock-names: list of names of clocks which are fed as the input >>> >> + to the given clock controller. >>> >> + >> > >> > Perhaps: >> > >> > + - clocks: list of the clock controller input clock identifiers, >> > from common clock bindings. Please refer the next section >> > to find the input clocks for a given controller. >> > >> > +- clock-names: list of the clock controller input clock names, >> > as described in clock-bindings.txt. >> > >> > ? >> > It's fine to resend just updated first patch from each series. > OK, > I'll modify the comment of 'clocks' and 'clock-names' and send only first patch. > > I have a question. Do you prefer to add the list of input clocks for > each clock domain as following? > Or it is not necessary? > > + Input clocks for top clock controller: > + - oscclk > + - sclk_mphy_pll > + - sclk_mfc_pll > + - sclk_bus_pll We are supposed to document all required input clocks somehow, I would keep the list in such form. The (example) cmu nodes are also a good documentation IMHO, they also show clearly which cmu (block) given clock is sourced from. -- Thanks, Sylwester