Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

[Greg KH]

On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
> The task was to fix  a warning which was shown while compiling a driver
> called NVEC. I wrote a brief description about how to enable support for
> a nVidya complaint embedded controller.

This makes no sense, what "task"?

> Signed-off-by:Varsha Ram T<varsharamt91@gmail.com>

Please use proper spaces.

Also, this doesn't match your From: line.  And, is this the name you use
to sign legal documents?


> ---
>  drivers/staging/nvec/Kconfig | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig
> index 9475e20..a65ad4c 100644
> --- a/drivers/staging/nvec/Kconfig
> +++ b/drivers/staging/nvec/Kconfig
> @@ -3,33 +3,33 @@ config MFD_NVEC
>  	depends on I2C && GPIOLIB && ARCH_TEGRA
>  	select MFD_CORE
>  	help
> -	    Say Y here to enable support for a nVidia compliant embedded
> -	    controller.
> +	Say Y to enable support for a nVidia complaint embedded controller.
> +	nVidia complaint embedded controller is used to communicate with EC.
> +	This is done through I2C bus.
> +	The request to the EC can be initiated by triggering a gpio line.
> +	The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time.


There's no way this is correct, look at how long your line is.

>  
>  config KEYBOARD_NVEC
>  	tristate "Keyboard on nVidia compliant EC"
>  	depends on MFD_NVEC && INPUT
>  	help
> -	  Say Y here to enable support for a keyboard connected to
> -	  a nVidia compliant embedded controller.
> +	Say Y here to enable support for a keyboard connected to a nVidia compliant embedded controller.

Why did you change these lines and the rest of the lines in this patch?

thanks,

greg k-h

Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

[Julian Andres Klode]

On 31 January 2015 at 17:29, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
>> The task was to fix  a warning which was shown while compiling a driver
>> called NVEC. I wrote a brief description about how to enable support for
>> a nVidya complaint embedded controller.
>
> This makes no sense, what "task"?
>
>> Signed-off-by:Varsha Ram T<varsharamt91@gmail.com>
>
> Please use proper spaces.
>
> Also, this doesn't match your From: line.  And, is this the name you use
> to sign legal documents?
>
>
>> ---
>>  drivers/staging/nvec/Kconfig | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig
>> index 9475e20..a65ad4c 100644
>> --- a/drivers/staging/nvec/Kconfig
>> +++ b/drivers/staging/nvec/Kconfig
>> @@ -3,33 +3,33 @@ config MFD_NVEC
>>       depends on I2C && GPIOLIB && ARCH_TEGRA
>>       select MFD_CORE
>>       help
>> -         Say Y here to enable support for a nVidia compliant embedded
>> -         controller.
>> +     Say Y to enable support for a nVidia complaint embedded controller.
>> +     nVidia complaint embedded controller is used to communicate with EC.
>> +     This is done through I2C bus.
>> +     The request to the EC can be initiated by triggering a gpio line.
>> +     The gpio line is a generic pin on integrated circuit whose input or output pin can be controlled by the user at run time.
>
>
> There's no way this is correct, look at how long your line is.
>

I'm not even sure if this level of detail is needed. Why should anyone
that reads the config option care how NVEC is enabled or communicated
with?

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed

[Marc Dietrich]

[-- Attachment #1: Type: text/plain, Size: 2211 bytes --]

Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode:
> On 31 January 2015 at 17:29, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
> >> The task was to fix  a warning which was shown while compiling a driver
> >> called NVEC. I wrote a brief description about how to enable support for
> >> a nVidya complaint embedded controller.
> > 
> > This makes no sense, what "task"?
> > 
> >> Signed-off-by:Varsha Ram T<varsharamt91@gmail.com>
> > 
> > Please use proper spaces.
> > 
> > Also, this doesn't match your From: line.  And, is this the name you use
> > to sign legal documents?
> > 
> >> ---
> >> 
> >>  drivers/staging/nvec/Kconfig | 20 ++++++++++----------
> >>  1 file changed, 10 insertions(+), 10 deletions(-)
> >> 
> >> diff --git a/drivers/staging/nvec/Kconfig b/drivers/staging/nvec/Kconfig
> >> index 9475e20..a65ad4c 100644
> >> --- a/drivers/staging/nvec/Kconfig
> >> +++ b/drivers/staging/nvec/Kconfig
> >> @@ -3,33 +3,33 @@ config MFD_NVEC
> >> 
> >>       depends on I2C && GPIOLIB && ARCH_TEGRA
> >>       select MFD_CORE
> >>       help
> >> 
> >> -         Say Y here to enable support for a nVidia compliant embedded
> >> -         controller.
> >> +     Say Y to enable support for a nVidia complaint embedded controller.
> >> +     nVidia complaint embedded controller is used to communicate with
> >> EC.
> >> +     This is done through I2C bus.
> >> +     The request to the EC can be initiated by triggering a gpio line.
> >> +     The gpio line is a generic pin on integrated circuit whose input or
> >> output pin can be controlled by the user at run time.> 
> > There's no way this is correct, look at how long your line is.
> 
> I'm not even sure if this level of detail is needed. Why should anyone
> that reads the config option care how NVEC is enabled or communicated
> with?

I didn't received the original mail, but I think this is related to a 
checkpatch warning which demands at least *three* lines of help text (we only 
have two). While the sense of such requirement is discussable, blowing up
an already complete help text just to avoid a checkpatch warning doesn't make 
much sense to me.

Marc

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

[Stephen Warren]

  On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
> The task was to fix  a warning which was shown while compiling a driver
> called NVEC. I wrote a brief description about how to enable support for
> a nVidya complaint embedded controller.

Please note that NVIDIA is spelled/capitalized as NVIDIA.