From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964775AbbBBR4b (ORCPT ); Mon, 2 Feb 2015 12:56:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42647 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932119AbbBBR4a (ORCPT ); Mon, 2 Feb 2015 12:56:30 -0500 Message-ID: <54CFBA3B.9090508@redhat.com> Date: Mon, 02 Feb 2015 12:56:11 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Dave Hansen , oleg@redhat.com CC: sbsiddha@gmail.com, luto@amacapital.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, fenghua.yu@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] x86,fpu: use disable_task_lazy_fpu_restore helper References: <20150129210723.GA31584@redhat.com> <1422640170-20020-1-git-send-email-riel@redhat.com> <1422640170-20020-4-git-send-email-riel@redhat.com> <54CBFBC7.7060304@linux.intel.com> In-Reply-To: <54CBFBC7.7060304@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/30/2015 04:46 PM, Dave Hansen wrote: > On 01/30/2015 09:49 AM, riel@redhat.com wrote: >> @@ -440,8 +440,9 @@ static inline fpu_switch_t >> switch_fpu_prepare(struct task_struct *old, struct ta >> new->thread.fpu_counter > 5); if (__thread_has_fpu(old)) { if >> (!__save_init_fpu(old)) - cpu = ~0; - old->thread.fpu.last_cpu >> = cpu; + task_disable_lazy_fpu_restore(old); + else + >> old->thread.fpu.last_cpu = cpu; > > What is the 'else' doing here? It seems a bit disconnected from > the other parts of the patch. Let me break that out into a separate patch, for reviewing clarity. INCOMING! - -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUz7o7AAoJEM553pKExN6DekMIAIuAFk437HUVDviJX9tx8his 2Jec8932I2+nd8OBzqBdCjiSUimLCNdT7eygf2UUdMciaNuHQ1CU1GAkM2MOglvo /ZYAGoZPbqdJZOQZp0HIzpqBGaqTjNoNfY46EVZyQgc/e3LVAfMZEF/SHhjLESEt gaJ0/ucRxl8a5C4qd29Pdgbn6jaionmEA1xrdYqfvQM32JVt4B7Qu/v2ZVCWDsCt W+TIEWFJga7u6vtKkfC4eHB0PPliMTn0N5bzCSk4zGZRtj+T8rVJ1eFcxhmEsWFs N6EF5CwGMVU0QvsWHK6Js2ELHAo+I1KJ7e/m0dHeBj/P4To835tnMh3a+IK0XWo= =rIwr -----END PGP SIGNATURE-----